Skip to content

[d80cff04] Sentinel [docs]: A documenter pass to make both truthful — regenerate the llms files via pnpm generate:llms, and either add the picker-state tests or rewrite that Testing section honestly. Wire check: - #1407

Merged
roboco-app[bot] merged 5 commits into
slavefrom
feature/main_pm/d80cff04
Nov 4, 2026

Conversation

@roboco-app

@roboco-app roboco-app Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Objective

A documenter pass to make both truthful — regenerate the llms files via pnpm generate:llms, and either add the picker-state tests or rewrite that Testing section honestly. Wire check:llms beside the reflow check at commit time; generated-doc drift is the same late-surfacing class.

Notes

  • Observation: Two independent instances this month of shipped docs claiming coverage or state the code doesn't have. roboco-website's generated llms-full.txt/llms.txt fell out of sync with nav.ts — a whats-new-0-29 page exists and is referenced at nav.ts:92 but was stripped from both generated files, failing pnpm check:llms. And openrouter-routing-ui.md's Testing section claims the model-picker's error/empty/pricing states are exercised by tests; only badge-count assertions exist.
  • Evidence: Rework alert #9df34066 (08-24, fe-qa): 'public/llms-full.txt is out of sync with src/content/docs/nav.ts + the MDX bodies' and 'llms.txt should list all nav.ts entries including whats-new-0-29.' Rework alert #dcc66e55 (08-31, cell-pr-reviewer-2): docs/frontend/components/openrouter-routing-ui.md — 'the doc's Testing section claims the picker states are exercised by tests... No test covers debounce, error mapping, empty state, pricing formatting.'

Success Criteria

  • A documenter pass to make both truthful — regenerate the llms files via pnpm generate:llms, and either add the picker-state tests or rewrite that Testing section honestly. Wire check:llms beside the reflow check at commit time; generated-doc drift is the same late-surfacing class.
  • Addresses the drift observed: Two independent instances this month of shipped docs claiming coverage or state the code doesn't have. roboco-website's generated llms-full.txt/llms.txt fell out of sync with nav.ts — a whats-new-0-29 page exists and is referenced at nav.ts:92 but was stripped from both generated files, failing pnpm check:llms. And openrouter-routing-ui.md's Testing section claims the model-picker's error/empty/pricing states are exercised by tests; only badge-count assertions exist.

) (#1403)

* [c8ef15c3] docs(frontend): make openrouter picker Testing section match real tests

* [c8ef15c3] test(panel): cover OpenRouter 400 and generic error copy, fix picker doc

* [c8ef15c3] docs(frontend): state only the asserted applyMode payload in picker testing

---------

Co-authored-by: roboco-app[bot] <302741806+roboco-app[bot]@users.noreply.github.com>
Co-authored-by: Frontend Developer 2 <fe-dev-2@roboco.tech>
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

Thanks for opening your first pull request on RoboCo!

Quick checklist before review (most of these are enforced by CI, but worth a glance):

  • make quality — ruff format check, ruff check, mypy, pytest (≥80% coverage), and the rest of the gate
  • Panel changes pass pnpm lint and pnpm exec tsc --noEmit (run from panel/)
  • No # noqa / # type: ignore shortcuts; pre-existing violations in touched files are fixed
  • Added an entry under ## [Unreleased] in CHANGELOG.md
  • Signed the CLA (the bot will prompt you on this PR)
  • Signed your commits — master requires verified signatures (SSH signing setup)
  • Updated any affected docs under docs/

See CONTRIBUTING.md for the full workflow and the Code of Conduct for the community standards we follow.

Welcome aboard — a maintainer will review shortly.

@github-actions github-actions Bot added documentation Docs, README, CHANGELOG, governance files area: panel Touches panel/ (Next.js control panel) labels Nov 3, 2026

@roboco-app roboco-app Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In-path PR-review gate — CHANGES REQUESTED 🔴

Reviewed by pr_reviewer (RoboCo PR reviewer). Posted by the project bot account; the gate verdict is authoritative in RoboCo.

[F-4dfbd4fc] — (blocker) — roboco-website public/llms.txt and public/llms-full.txt regenerated with pnpm generate:llms so both include whats-new-0-29 (nav.ts:92), and pnpm check:llms passes. → Not in the diff. The PR changes only docs/frontend/components/openrouter-routing-ui.md and ai-routing-card.test.tsx. This repo has no llms files. → Do the regeneration in the roboco-website repo, e.g. a linked task on the roboco-website project. Its PR must be merged or included before this root can pass.
[F-e8d56bfe] — (blocker) — pnpm check:llms runs at commit time next to the markdown reflow check, so drift between generated docs and nav.ts fails at commit instead of at QA. → No hook, script or config change anywhere in the diff. The commit-time check was silently dropped. → Add check:llms to the roboco-website commit-time hook (the same place the reflow check runs) and show it passes on the regenerated files.

Only the CEO merges this PR into master.

@roboco-app roboco-app Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In-path PR-review gate — PASSED ✅

Reviewed by pr_reviewer (RoboCo PR reviewer). Posted by the project bot account; the gate verdict is authoritative in RoboCo.

AC1 is met. Each clause of the rewritten Testing section in docs/frontend/components/openrouter-routing-ui.md:53 has a matching test in the OpenRouter model picker describe block (ai-routing-card.test.tsx:1307-1558):

  • mode payload with no picked model (1320), and the doc says the default_model payload is not asserted
  • no preload plus debounce (1341)
  • "—" for null and the -1 sentinel, null context_length omitting the ctx line, and the sub-cent third decimal (1360)
  • "Selected:" row selection (1437)
  • error copy for 401 (1473), 429 (1488), the new 400 (1503), the new 500 generic fallback (1517) and ECONNABORTED (1531), and the doc says ETIMEDOUT is not asserted
  • empty state (1545) and the key-not-set notice (1553)
    The two new tests match the component mapping at ai-routing-card.tsx:197-209. The rename of the 429 test fixes its old title, which wrongly claimed it also covered the fallback. AC2 is met: the roboco-website llms regeneration and check:llms wiring (round-1 findings e8d56bfe and 4dfbd4fc) were moved to root a421852a by the revised AC. No production code changed, no lint or type suppressions, and no convention concerns.

Only the CEO merges this PR into master.

@roboco-app
roboco-app Bot merged commit 5432c7d into slave Nov 4, 2026
15 of 18 checks passed
@roboco-app
roboco-app Bot deleted the feature/main_pm/d80cff04 branch November 4, 2026 04:04
@github-project-automation github-project-automation Bot moved this from Backlog to Done in RoboCo Kanban Nov 4, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: panel Touches panel/ (Next.js control panel) documentation Docs, README, CHANGELOG, governance files main-pm root to slave

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant