Skip to content

[4eb71d9f] Fix wedge-ledger PR-gate findings: single post-commit check, verb in cycle, artifacts - #1376

Merged
roboco-app[bot] merged 5 commits into
feature/backend/c79ba38e--6966e3d8--c87fbc0dfrom
feature/backend/c79ba38e--6966e3d8--c87fbc0d--4eb71d9f
Nov 5, 2026
Merged

roboco-app[bot] merged 5 commits into
feature/backend/c79ba38e--6966e3d8--c87fbc0dfrom
feature/backend/c79ba38e--6966e3d8--c87fbc0d--4eb71d9f

Conversation

@roboco-app

@roboco-app roboco-app Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Resolve all five open pr_gate findings on the wedge ledger PR (#1364), branch feature/backend/c79ba38e--6966e3d8--c87fbc0d. Forwarded verbatim:

[dbe52f00 blocker] roboco/services/task.py:~13984 — _emit_status_transition_audit calls _maybe_schedule_wedge_ledger_check twice (lines ~13948 and ~13984): two strikes per arrival, so default N=5 trips on the 3rd static arrival; the two tasks also race on the same marker read-modify-write. Delete one call; add a test that runs the REAL _emit_status_transition_audit and asserts exactly one run_wedge_ledger_check task is scheduled (current tests call check_transition directly and miss this).

[360d8ebe major] roboco/services/task.py:~14000 — the check is scheduled with asyncio.create_task mid-transaction on a fresh session; it can read pre-commit state, force BLOCKED before the caller commits its own status, or have its wedge_ledger marker overwritten when the caller flushes task.markers. If a trip is lost to the caller overwriting the status, the ledger persists tripped=True and check_transition returns early on ledger['tripped'], so the task never trips again until the fingerprint moves. Fix: run the check post-commit (after-commit hook or outbox), or do the ledger fold in the caller's session and only defer the trip.

[a5795a7f major] roboco/services/notification.py:~312 — the CEO cycle lines render only timestamp, actor, role and from->to; the audit event (verb proxy, e.g. task.pr_fail / task.request_changes) is collected in _transition_cycle but never shown. Include the event/verb in each rendered line; if the verb is not recoverable from the audit row, record it in the audit details at the chokepoint. Update tests.

[36f665f3 minor] roboco/services/notification.py:~318 — body says 'Full cycle (oldest last)' but _transition_cycle reverses a DESC query so rows come oldest FIRST. Change the label to 'oldest first' (also in the _transition_cycle and wedge_cycle docstrings).

[d0ac020c blocker] panel/lib/lifecycle.json, agents/prompts/_generated/*.md (all 12), docs/rag/lifecycle/intent-verbs.md, docs/rag/lifecycle/status-transitions.md — stale regeneration: diff deletes cancel_leaf, the devops role/verbs and task_time and drops 'start' from i_will_plan/i_will_work_on composes, though lifecycle.py still defines them. This task has no lifecycle changes. Sync the branch onto its base (sync_branch), then regenerate (scripts/regenerate_verb_tables.py and the lifecycle export) or revert these files so the PR diff touches none of them. Verify with the diff that none of those paths remain changed.

Keep scope to roboco/services/task.py, notification.py, wedge_ledger.py, their tests, and the generated artifacts reverted. Run make gate before submitting.

@github-project-automation github-project-automation Bot moved this to Backlog in RoboCo Kanban Nov 3, 2026
@github-actions github-actions Bot added documentation Docs, README, CHANGELOG, governance files area: panel Touches panel/ (Next.js control panel) area: services Touches roboco/services/ (business logic, side effects) tests Test suite changes area: agents Touches agents/ (prompts, role config) labels Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

Thanks for opening your first pull request on RoboCo!

Quick checklist before review (most of these are enforced by CI, but worth a glance):

  • make quality — ruff format check, ruff check, mypy, pytest (≥80% coverage), and the rest of the gate
  • Panel changes pass pnpm lint and pnpm exec tsc --noEmit (run from panel/)
  • No # noqa / # type: ignore shortcuts; pre-existing violations in touched files are fixed
  • Added an entry under ## [Unreleased] in CHANGELOG.md
  • Signed the CLA (the bot will prompt you on this PR)
  • Signed your commits — master requires verified signatures (SSH signing setup)
  • Updated any affected docs under docs/

See CONTRIBUTING.md for the full workflow and the Code of Conduct for the community standards we follow.

Welcome aboard — a maintainer will review shortly.

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

All contributors have signed the CLA. Thank you!
Posted by the CLA Assistant Lite bot.

@github-actions github-actions Bot removed documentation Docs, README, CHANGELOG, governance files area: panel Touches panel/ (Next.js control panel) area: agents Touches agents/ (prompts, role config) labels Nov 4, 2026
The automatic codegen ran with the clone root's old code (the worktree
import hook missed .venv-<digest>, fixed in #1524) and committed drift
to these 15 files. They now match the base branch byte for byte, as
finding e17ca419 asks; be-dev-2 could not read the base content itself.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rennf93
rennf93 force-pushed the feature/backend/c79ba38e--6966e3d8--c87fbc0d--4eb71d9f branch from 207c67b to 4f182e5 Compare November 4, 2026 23:36
@github-actions github-actions Bot added documentation Docs, README, CHANGELOG, governance files area: panel Touches panel/ (Next.js control panel) area: agents Touches agents/ (prompts, role config) labels Nov 4, 2026
…ure/backend/c79ba38e--6966e3d8--c87fbc0d--4eb71d9f
@github-actions github-actions Bot removed documentation Docs, README, CHANGELOG, governance files area: panel Touches panel/ (Next.js control panel) area: agents Touches agents/ (prompts, role config) labels Nov 5, 2026
@github-actions github-actions Bot added the documentation Docs, README, CHANGELOG, governance files label Nov 5, 2026
@roboco-app
roboco-app Bot merged commit 3c087cc into feature/backend/c79ba38e--6966e3d8--c87fbc0d Nov 5, 2026
10 of 11 checks passed
@roboco-app
roboco-app Bot deleted the feature/backend/c79ba38e--6966e3d8--c87fbc0d--4eb71d9f branch November 5, 2026 03:55
@github-project-automation github-project-automation Bot moved this from Backlog to Done in RoboCo Kanban Nov 5, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: services Touches roboco/services/ (business logic, side effects) cell/backend documentation Docs, README, CHANGELOG, governance files tests Test suite changes to feature/backend/c79ba38e--6966e3d8--c87fbc0d

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant