Skip to content

feat(i18n): extract device list chrome (batch 4)#1155

Open
JamieRuderman wants to merge 1 commit into
i18n/extract-settingsfrom
i18n/extract-devicelist
Open

feat(i18n): extract device list chrome (batch 4)#1155
JamieRuderman wants to merge 1 commit into
i18n/extract-settingsfrom
i18n/extract-devicelist

Conversation

@JamieRuderman

Copy link
Copy Markdown
Member

Summary

Batch 4 of Phase 4 — the first slice of the device/connection surfaces: the device-list chrome. 20 keys (deviceList.*) across DevicesHeader, DeviceListEmpty, and DevicesActionBar, translated to ja/de/es.

Covers the empty/no-results states, the AWS demo-device onboarding copy, the Cachengo-brand welcome, and the multi-select action bar (tag/script controls, selection labels).

Stacked on i18n/extract-settings (#1154).

Notes / scoping

  • Column labels deferred deliberately. The device-list column headers come from Attributes.tsx — a module-level static registry of ~71 label: strings evaluated once at import. Making those translatable and reactive to language changes needs a small architectural change (labels → keys resolved at render time), so it gets its own dedicated batch rather than being rushed in here.
  • Conditional noun splitYour {searched ? 'search' : 'filter'} returned no results became two keys so each language reads naturally.
  • Brand copy — the Cachengo/Telepath strings render only for that brand build; product names (Telepath, Cachengo, Symbiote Node, Rent-A-Node) are kept untranslated, surrounding words localized.
  • DevicesPage and DeviceListHeaderCheckbox had no user-facing strings (pure composition), so they're untouched.

Verification

  • i18n:check passes — 4 locales × 3 namespaces, no missing/dead keys, no empty English.
  • tsc clean; production build passes.

🤖 Generated with Claude Code

@JamieRuderman

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 99b5373e03

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant