Skip to content

[bugfix] Treat properly Slurm constraints with .#3667

Open
Guy-Coates wants to merge 1 commit into
reframe-hpc:masterfrom
Guy-Coates:constraint-fix-master
Open

[bugfix] Treat properly Slurm constraints with .#3667
Guy-Coates wants to merge 1 commit into
reframe-hpc:masterfrom
Guy-Coates:constraint-fix-master

Conversation

@Guy-Coates
Copy link
Copy Markdown

The reframe slurm node constraint validator rejects features with a "." in the name (eg nodes with Feature=c5.xlarge defined in slurm).

This results in Reframe generating no tests when attempting to target nodes of that type using --constraint=c5.xlarge in the systems.partitions.access config.

This PR relaxes the validation/tokenisation regexes to allow ".".

@vkarak vkarak requested review from jack-morrison and vkarak May 18, 2026 21:49
@vkarak vkarak requested review from ekouts and removed request for ekouts and jack-morrison May 18, 2026 21:49
@vkarak vkarak moved this to In Progress in ReFrame Backlog May 18, 2026
@vkarak vkarak moved this from In Progress to Todo in ReFrame Backlog May 18, 2026
@vkarak vkarak added this to the ReFrame 4.10 milestone May 18, 2026
@vkarak vkarak changed the title [bugfix] Allow "." in slurm features [bugfix] Treat properly Slurm constraints with . May 18, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.25%. Comparing base (1aca15b) to head (f824600).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3667   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files          62       62           
  Lines       13591    13591           
=======================================
  Hits        12402    12402           
  Misses       1189     1189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Lgtm. Since we are not going to make another patch release for 4.9 (4.10 is around the corner), we'd need to rebase this PR on develop.

@github-project-automation github-project-automation Bot moved this from Todo to In Progress in ReFrame Backlog May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants