Repository navigation
fix: preserve converted PDF URL when hydrating parse results - #117
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
handle_url_response()hydrates a URL result, it reconstructsFullParseResponsewithout copyingpdf_url. The same helper preserves that field for inline results. A caller therefore loses the converted PDF link depending on response size.Copy
response.pdf_urlinto the hydrated response. Four offline regressions compare inline and URL results with a signed PDF URL and with no URL, also checking that hydration retains the document text and other existing helper metadata.Validation:
tests/api_resources(requires the API mock server) and the default-excluded livetests/e2e. No live API or storage requests.git diff --checkpass.Need help on this PR? Tag
@codesmith-botwith what you need.