You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Look up config properties in the published reference, not the UI sample - #455
Ask AI's lookup_config_property tool read redpanda-properties.json from the UI bundle. That file is a 9-property sample, and production serves it too, so common properties such as default_topic_replications and write_caching_default came back "not found". The tool tells the model to use it for grounded values, so it was steering answers away from exact values.
The tool now reads the reference the property tooltips already use: the file that <meta name="properties-json-url"> names, which the docs build publishes per release. Today that's /streaming/current/reference/_attachments/redpanda-properties-v26.2.4.json, with 691 properties. Solutions pages carry the same meta.
On a page with no meta, it says the page names no property reference, so the model falls back to docs search. It never reads the sample outside the docs-ui preview.
In the docs-ui preview, which has no docs build behind it, it still reads the bundled sample.
It caches by URL, and retries after a failed fetch.
It also returns cloudEditable, cloudReadonly and cloudByocOnly when the reference has them.
Tests: tests/property-lookup-tool (7 cases), wired into test:all and validate-build.yml. With main's loader restored, 6 of the 7 fail. The tests pass on Node 18 (node:18-alpine) and lint is clean. A run against the live 26.2.4 file returns default_topic_replications (default 1, cluster) and write_caching_default, and reports an unknown name as not found.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Walkthrough
The property lookup tool now uses the property-reference URL in page metadata. UI-preview pages without that URL use the UI-root JSON file; other pages without a reference return an error. Successful references are cached by URL, and failed loads can be retried. Lookup results include three Cloud-related fields. New tests cover reference selection, caching, retries, and preview fallback. The tests are added to the full test sequence and build validation workflow.
sequenceDiagram
participant PageMetadata
participant lookup_config_property
participant fetch
PageMetadata->>lookup_config_property: provide properties-json-url
lookup_config_property->>fetch: request property reference
fetch-->>lookup_config_property: return property records
lookup_config_property-->>PageMetadata: return property data and Cloud fields
Loading
Suggested reviewers:feediver1
Merge Risk: Minimal · up to fce83
The property lookup change is mergeable after normal checks; no actionable risk is established by the supplied evidence.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description check
The description clearly explains the change from the UI sample to the published property reference, fallback behavior, caching, returned fields, and test coverage.
Title check
The title clearly and concisely summarizes the main change: looking up configuration properties in the published reference instead of the UI sample.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 3 functions across 2 files. (3 skipped: 3 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches: 💡 1
📝 Generate docstrings: 💡
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
ESLint
If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.
package.json
Parsing error: Unexpected token :
Comment @coderabbitai help to get the list of available commands.
1 paths audited Performance: 44 (🟢 up 4 from production) Accessibility: 89 (no change from production) Best Practices: 83 (no change from production) SEO: 89 (no change from production) PWA: - View the detailed breakdown and full score reports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ask AI's
lookup_config_propertytool readredpanda-properties.jsonfrom the UI bundle. That file is a 9-property sample, and production serves it too, so common properties such asdefault_topic_replicationsandwrite_caching_defaultcame back "not found". The tool tells the model to use it for grounded values, so it was steering answers away from exact values.The tool now reads the reference the property tooltips already use: the file that
<meta name="properties-json-url">names, which the docs build publishes per release. Today that's/streaming/current/reference/_attachments/redpanda-properties-v26.2.4.json, with 691 properties. Solutions pages carry the same meta.cloudEditable,cloudReadonlyandcloudByocOnlywhen the reference has them.Tests:
tests/property-lookup-tool(7 cases), wired intotest:allandvalidate-build.yml. With main's loader restored, 6 of the 7 fail. The tests pass on Node 18 (node:18-alpine) and lint is clean. A run against the live 26.2.4 file returnsdefault_topic_replications(default 1, cluster) andwrite_caching_default, and reports an unknown name as not found.