Repository navigation
DOC-7267 Record the node_redis, redis_py and NRedisStack lessons in client-quirks - #4494
Merged
Merged
Conversation
…lient-quirks The DOC-7267 cleanup PRs (#4482, #4484, #4486) left their durable findings only in commit bodies, where a future sweep would not see them before authoring. They now sit in the per-client sections of the skill's quirks reference: node-redis lists every command under an uppercase and a camelCase key and modules are client.<namespace>.<method>; reply types come from source, not the .d.ts; ten redis-py methods raise NotImplementedError; an NRedisStack async entry is never a copy of the sync one, and the scan overloads return IAsyncEnumerable. Directive: when a sweep finds a client convention that is not in this file, add it here in the same PR Ticket: DOC-7267 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Contributor
🧠 Redis MemoryFound 5 related items from repository history (5 new this commit):
Memory updated at eae1eda |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably didn't need to be a separate PR, TBH, but Claude thought of it and did it automatically after the other thing merged.
Summary
Promotes the durable findings from the DOC-7267 cleanup PRs (#4482, #4484, #4486) into
.claude/skills/command-api-mapping/reference/client-quirks.md, so a future sweep sees them before authoring:client.<namespace>.<method>; take reply types from source, not the.d.ts; how to get the sources andtsc.NotImplementedError(recordunsupported, don't author); resolve module methods against the class for the command prefix; how to pin a version.IAsyncEnumerable<T>; verify by reflection.29 lines added to one reference file. No data changes.
Ticket: DOC-7267
🤖 Generated with Claude Code
Note
Low Risk
Documentation-only changes to internal reference; no runtime or data impact.
Overview
Promotes DOC-7267 lessons into
client-quirks.mdso future command-mapping work matches real client behavior.node_redis: Prefer camelCase exports from
index.ts(not dotted module names likeBF.ADD); useclient.<namespace>.<method>for modules. Derive reply types fromtransformReplyin source (RESP2 when both exist), not expanded.d.ts; use declarations only for names/arity andtsc --strict. Adds tooling notes (gh apitarball, localnpm+tsc, sandbox off).redis_py: Documents methods that only raise
NotImplementedError— leave empty signatures and mark unsupported; clarifies module classes and repeated method names; adds version pinning viapip install --target+PYTHONPATH.nredisstack / StackExchange.Redis: Async rows are not sync copies (
Asyncsuffix,Task<T>/IAsyncEnumerablefor scans with correct params); core entries omit return type insignatureand putTask<T>inreturns.type; verify with reflection on pinned assemblies.go-redis: Fixes prior guidance — keep
ctx context.Contextin signature and params.Reviewed by Cursor Bugbot for commit eae1eda. Bugbot is set up for automated code reviews on this repo. Configure here.