Skip to content

DO NOT MERGE: Bugbot probe 2, arm B - #4452

Closed
andy-stark-redis wants to merge 1 commit into
mainfrom
DOC-bugbot-probe2-b-expt
Closed

andy-stark-redis wants to merge 1 commit into
mainfrom
DOC-bugbot-probe2-b-expt

Conversation

@andy-stark-redis

@andy-stark-redis andy-stark-redis commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Throwaway probe, arm B. Close without merging.


Note

Low Risk
Single-line change in a local tutorial example with no production or security impact.

Overview
Removes .sort_by(aggregations.Desc("@avg_price")) from the agg_avg step in search_tutorial.py, so the sample aggregation only groups by category and averages price without ordering results.

The printed example comment still shows Computers first; row order may no longer match that snippet unless Redis returns the same default order. The hidden assertion still only checks six category rows, so CI behavior is unchanged aside from losing the sort demonstration in that step.

Reviewed by Cursor Bugbot for commit 7206719. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

🧠 Redis Memory

Found 7 related items from repository history (2 new this commit):

Memory updated at 7206719

Probe PR for checking how Cursor Bugbot reviews an aggregation change. This drops the
sort from agg_avg.

Constraint: this branch must never merge
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@andy-stark-redis

Copy link
Copy Markdown
Contributor Author

bugbot run verbose=true

@cursor

cursor Bot commented Nov 4, 2026

Copy link
Copy Markdown

Bugbot request id: b135936e-13c2-4f44-9edf-42a4e369abd5

@cursor

cursor Bot commented Nov 4, 2026

Copy link
Copy Markdown

Bugbot rules debug

No rules were used for this review.

https://cursor.com/docs/bugbot#team-rules

Bugbot request id: b135936e-13c2-4f44-9edf-42a4e369abd5

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7206719. Configure here.

req = (
aggregations.AggregateRequest("*")
.group_by("@category", reducers.avg("@price").alias("avg_price"))
.sort_by(aggregations.Desc("@avg_price"))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aggregation example drops sort order

Medium Severity

The agg_avg request no longer applies sort_by on @avg_price, so group order is undefined. The expected output still lists Computers first at 864.495, which only holds under descending sort, and the aggregation tutorial still presents this step as ordering groups with SORTBY.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 7206719. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant