Repository navigation
docs(MOD-20266): give the Gateway data plane its own sign-in audience - #4428
Conversation
|
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🧠 Redis MemoryFound 5 related items from repository history (5 new this commit):
Memory updated at 506122d |
Summary
api://redis-irisas the Data Plane's sign-in audience. The Data Plane now refuses to start with that value, so following the docs would break a deploy.api://context-gateway-dp, explains why the shared audience is unsafe, and adds a short upgrade path for deployments already on it.redis-irisrelease exists, so the1.0.0b2pins stay.Changes
Data Plane sign-in audience
Driven by redislabsdev/iris#2203 (MOD-20266, "Give Context Gateway MCP sign-in its own audience").
The Data Plane's
validateOIDCnow refusesauth.oidc.audience: api://redis-iris(context-gateway/dataplane/internal/infrastructure/config.go,sharedIrisAudience). The shared audience would let an MCP client's token open Agent Memory and Playbook too. The Helm README andvalues.yamlnow say to register a separate API, for exampleapi://context-gateway-dp, and the README carries an upgrade note. The specdocs/specs/MOD-19226-context-gateway-mcp-oauth-sign-in.mdaddsapi://redis-iristo S10 and A2.content/operate/iris/context-gateway/self-managed/authentication.mdaudiencerow now usesapi://context-gateway-dpand says not to useapi://redis-iris.### Upgrade from the shared audiencesection, matching the Helm README note: register the API and assign roles, setdataplane.config.auth.oidc.audience, upgrade, then MCP clients sign in again.content/develop/ai/context-engine/context-gateway/mcp.md: one line in "Sign in with your identity provider" saying the token must be for the Gateway's own API, and a token for the shared Iris audience alone doesn't open a Gateway.content/operate/iris/context-gateway/self-managed/operations.md: one line in "Upgrade the chart" pointing at the new upgrade section.The Control Plane and Iris UI examples keep
api://redis-iris. The Helm README still uses it forcontrolplane.config.auth.oidcand the UIsso.audience.Checked, no docs change
9b1fd51that touchcontext-gateway/: Fixed broken relrefs #2325 moves the trace attribute names into a shared package with the same values, and OP: add RediSearch v2.8.31 and v2.10.24 release notes #2324 changes the cloud Neptune charts only. Neither affects the self-managed or developer pages.redis-irisumbrella,global.irisonly input): the umbrella doesn't include Context Gateway, and the Identity Service chart notes say nothing changes withoutglobal.iris. The Gateway deploy page installs Identity Service standalone, so it still holds.NAMESPACE__TOOL): the Gateway docs have no dotted-name caveat to remove. The quickstart's CLI example callsscheduling__filter_providerin full mode, which1.0.0b2already sends unchanged. The fix ships in the next release.--write-envdescription (mode0600, key never printed) still holds.redis-iris: latest is still1.0.0b2(2026-10-30), so the pinned versions stay. The "CLI rejects--jsonpathwith--group-by" note also stays, since main hasn't changed that.1c8e7ba4..6d9dc672: no Context Gateway files changed.Overlap with #4419
#4419 doesn't touch
authentication.mdormcp.md. It edits the "Upgrade the chart" section ofoperations.mda few lines above the new pointer, andgit merge-treemerges the two cleanly.🤖 Generated with Claude Code
Note
Low Risk
Documentation-only updates; no runtime or configuration behavior changes in this PR.
Overview
Documentation now matches the Data Plane refusing
api://redis-irisas the MCP OIDC audience (MOD-20266). Operators and developers are told to register a Data Plane–only API (for exampleapi://context-gateway-dp), not the shared Iris audience used by the console and Control Plane.On authentication, the
audiencetable row and new guidance explain why a shared audience would let MCP tokens reach Agent Memory and Playbook, that startup fails withapi://redis-iris, and that dual-audience tokens are unsafe. A new Upgrade from the shared audience section lists IdP registration, config change, chart upgrade, and client re-sign-in.MCP adds one sentence that IdP tokens must target the Gateway API. Operations → Upgrade the chart warns to migrate audience before upgrading when sign-in still uses the shared value.
Reviewed by Cursor Bugbot for commit 506122d. Bugbot is set up for automated code reviews on this repo. Configure here.