Repository navigation
refactor: GE train 3 — run-qd, capture tags, serialize and lexical tiers as named steps, plus a stricter tangle gate (answers byte-identical) #721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joyful-ii-V-I
wants to merge
44
commits into
main
Choose a base branch
from
integration/train-ge3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13,944
−4,470
Open
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
cf89ac8
refactor(quality): runQualityDelta in named phases, one row model for…
joyful-ii-V-I eb05d07
refactor(quality): --quality-delta computes silently, decides each ro…
joyful-ii-V-I 2d1a6f9
refactor(quality): qdCountField reuses rw::countField
joyful-ii-V-I 6abf83c
qd tangle: rule (b) gates; the ratchet reads the range base (TANGLE-G…
joyful-ii-V-I b9418fa
qd tangle: the ratchet against the range base GATES (QD-RATCHET-BASE,…
joyful-ii-V-I e849e1d
shstatus: one nesting budget for the shell lexer and parser; a cut sc…
joyful-ii-V-I e01533c
qd: re-file two-bit-era defect-shape acks to the three-bit key (CR712…
joyful-ii-V-I 119dca4
docs: tangle gates, shell_cut, two-bit ack re-filing — README, EVALS,…
joyful-ii-V-I 82d6580
qd dogfood: pastBacktick and parseShellScan helpers (own-range qd)
joyful-ii-V-I 13f3263
qd dogfood: one budget guard in skipParen; split defectRowKeysBothSch…
joyful-ii-V-I d78e9bb
qd: ack the shstatus.h detail:: signature rows (nesting budget thread…
joyful-ii-V-I 079594b
qd: tangle's gating rule only in the present-only tangle legend; pins
joyful-ii-V-I c3d395d
qd: fit the tangle exception into the MCP and compact legend budgets;…
joyful-ii-V-I 1116920
docs: LIMITS.md lists kMaxShellNest (replaces kMaxSubDepth)
joyful-ii-V-I a1ab35d
qd: shell_cut= is a QdRootField and its legend sentence is present-only
joyful-ii-V-I be80b0b
refactor(ingest): captureTagsFacts runs one match through named steps
joyful-ii-V-I 48c3e38
refactor(ingest): the declarator climb's stop set and wrapper test re…
joyful-ii-V-I d1ae284
refactor(ingest): langidentity ceiling 321 -> 317 (captureTagsFacts' …
joyful-ii-V-I 61c19e8
refactor(ingest): captureTagsFacts decides a definition's identity on…
joyful-ii-V-I 6b1f8d6
refactor(ingest): definition steps spell the callable test and the C+…
joyful-ii-V-I 76b36a1
refactor(ingest): captureTagsFacts' language rules dispatch once; lan…
joyful-ii-V-I 23d6c36
refactor(ingest): the Ruby class-side bind is inline in its language …
joyful-ii-V-I 9686a6c
refactor(ingest): pin the tags pass's three invariant-backed equivale…
joyful-ii-V-I dc15bce
refactor(serialize): the map as named steps — rows, order, groups, le…
joyful-ii-V-I d871b97
refactor(serialize): one writer for the roots table, the emit order a…
joyful-ii-V-I 3a8bad7
refactor(serialize): the module-scope clause as its presence scan, no…
joyful-ii-V-I 4b6575c
refactor(serialize): the map header's coverage attributes composed on…
joyful-ii-V-I de2e52e
refactor(serialize): one MapPlan for both map dialects; the JSON head…
joyful-ii-V-I b5889aa
refactor(serialize): planMap's two equivalence pins read fields, not …
joyful-ii-V-I 8e1c5d3
refactor(lexical): lexicalScoresTiered reads as its named BM25 steps
joyful-ii-V-I 739151c
refactor(lexical): the BM25 (k1, b) travel with the corpus statistics…
joyful-ii-V-I b6ae53e
refactor(lexical): the BM25 fold phase is a type, and margin arming a…
joyful-ii-V-I 914c404
showcase: the 11-20 capture stays main's; the train re-records once a…
joyful-ii-V-I 3e20541
Re-record the showcase once on the composed GE train 3 tip; re-pin qs…
joyful-ii-V-I 9683e45
test(qdentryceilingcheck): arm L reads the three-exception wording (T…
joyful-ii-V-I 147c732
showcase: the --compress demo expands collapseBlankLineRuns (compress…
joyful-ii-V-I cbed31d
Re-record the 11-22 showcase once more on the composed tip (the --com…
joyful-ii-V-I df9f835
refactor(quality): QdRowModel's row layout enum is RowShape, not Shape
joyful-ii-V-I c54b111
skills: quality-bar description fits the 5,400-char set budget (5,416…
joyful-ii-V-I 98f2b82
docs: refresh the counts snapshot (gates.scripts 854 -> 866; gendocsm…
joyful-ii-V-I 50c9b66
fix(quality): --ack-only's "gating" is an exact token; the verdict fo…
joyful-ii-V-I a362e42
fix(quality): CR721 qd-only findings: clone-group next=, cut shell tr…
joyful-ii-V-I 4cce67d
skills: quality-bar keeps its pinned phrases; the trim comes from unp…
joyful-ii-V-I 6964b9d
test: the CR721 arms test each new call's exit status (prereview CI10)
joyful-ii-V-I File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ### Fixed — format-arity acks written by 0.6.10 and earlier match again | ||
|
|
||
| The unchecked-status facet widened the facet bits of a defect-shape site value from two to three, which changed the ack key of every row holding a site whose hash had bit 2 set (about half of all one-site rows; 4 of 8 in a fixture sample): an ack written by 0.6.10 or earlier stopped matching, the row gated again and the ack was listed stale. Such an ack is now re-filed to its current key on read (counted in `acks_rekeyed_by_scheme=`) and written back healed by the next `--quality-ack`. Only rows whose key moved are affected; acks written since are unchanged. New gate `test/defectackschemecheck.sh`, its legacy key recorded from the released 0.6.9 binary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ### Fixed — a deeply nested shell script no longer crashes `--quality-delta` | ||
|
|
||
| The shell lexer and parser behind the Bash defect-shape facets recursed without a bound on subshells, brace groups, `if` and quote/substitution nesting; a test script 5,000 levels deep ended the run on SIGSEGV. One nesting budget (64 levels) now covers the lexer and the parser; a script that reaches it is cut there, and the run says so with `shell_cut=N` on the `<quality-delta>` root (and `"shell_cut"` in `--json`): N shell files whose scan stopped, what lies deeper was not judged. The old silent 40-level substitution cap is gone. New gate `test/shellnestcheck.sh` (generated scripts, never committed). | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ### Changed — `--quality-delta`'s tangle kind gates a new, crossing or growing tangle | ||
|
|
||
| `tangle` was report-only. A row now gates (exit 2) when the function is new at tangle 6.0 or more, crossed 6.0, or its score grew against the range base while over 6.0; a moved body and test code never gate, and a row an input rose on while the score held stays `sev="minor"`. The best-since-tag ratchet is now a facet (`ratchet=`) on those rows, not a row of its own, so a function that only sits above its tag best no longer prints. Replayed on the 20 merges before 8861b0d4d (tangle kind, range form): main gated 0 rows; this gates 9 over 5 PRs, every one a function that crossed or grew in its own PR (#702 `runLsp` 2.1→11.0, eight growth rows of a tenth or more), and the four rows on functions that did not grow in their PR print nothing. What it does not mean: a function already over 6.0 that the change leaves no worse never gates. Method and table: `docs/EVALS.md`, the thirteen kinds. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Describe the limit in parser frames, not shell nesting levels.
An unquoted command substitution uses one
parseSubsframe and oneparseCommandframe. With 32 nested substitutions, the innermost command already needs a 65th frame. Also, a parser cut can skip later commands at top level, not just deeper code. Describe the 64-frame budget and say that the scan may omit the rest of the token stream. Apply the same wording to the limits table and both legends.Based on learnings, verify a numeric threshold against the runtime scale of the value it measures.
Source: Learnings