fix(install-dynamic-plugins): clear stale npm hashes before cleanup (RHDHBUGS-3900) - #5578
Conversation
cdf094a to
b95f6ba
Compare
|
The container image build workflow finished with status: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.10 #5578 +/- ##
=================================================
+ Coverage 41.03% 69.69% +28.65%
=================================================
Files 121 111 -10
Lines 2220 4715 +2495
Branches 562 536 -26
=================================================
+ Hits 911 3286 +2375
- Misses 1304 1428 +124
+ Partials 5 1 -4
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
The container image build workflow finished with status: |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
306d173 to
a5e524f
Compare
|
The container image build workflow finished with status: |
When a local/npm plugin is reinstalled into the same directory after a config change, stale plugin_path_by_hash entries caused the final cleanup pass to remove the freshly installed plugin (RHDHBUGS-3900). Mirror the OCI installer behavior by popping hash keys for the target directory after npm/local extraction. Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
a5e524f to
59be643
Compare
|
The container image build workflow finished with status: |
Pin actions/setup-python@v6.3.0 and run tests via `python -m pytest` so CI does not use the runner's broken ~/.local/bin/pytest shim. Leave existing pip install lines unchanged for SonarCloud. Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
|
|
The container image build workflow finished with status: |
|
/hold Let's see if we need to integrate this for 1.10.5 (currently in CF) or hold until 1.10.6 |
59b7654
into
redhat-developer:release-1.10
|
Ah, I was just going to ask on the rhdh-release Slack channel, but it looks like this got merged already. Anyway, I guess it should be fine to integrate this in 1.10.5 since the 1.10.5 RC builds have not started yet, right @polasudo ? |
|
Looking at the updates, they have not yet started so it should be fine |
|
i was actually going to see if we could slip this into 1.10.5 to avoid it showing up in the demo, so this is good. thanks @rm3l @Fortune-Ndlovu @polasudo |
5 participants
Summary
plugin_path_by_hashentries for npm/local installs after extraction (same as OCI already does), so the end-of-run cleanup does not delete a plugin that was just reinstalled when the dynamic-plugins PVC still has a prior config hash.pluginConfigoverride without requiring a pod restart.Jira: RHDHBUGS-3900