Skip to content

chore: update node headers to v24.21.0 - #5572

Merged
nickboldt merged 1 commit into
redhat-developer:mainfrom
jonkoops:chore/node-headers-v24.21.0
Oct 1, 2026
Merged

nickboldt merged 1 commit into
redhat-developer:mainfrom
jonkoops:chore/node-headers-v24.21.0

Conversation

@jonkoops

@jonkoops jonkoops commented Oct 1, 2026

Copy link
Copy Markdown
Member

Align vendored node-gyp headers and .nvmrc with the ubi10/nodejs-24 skeleton image on main (Node v24.21.0 after #5565). Fixes hermetic PR image builds that failed when the base image bumped without a matching node-v24.21.0-headers.tar.gz.

Align vendored node-gyp headers and .nvmrc with the ubi10/nodejs-24 skeleton
image on main (Node v24.21.0 after redhat-developer#5565).

Signed-off-by: Jon Koops <jonkoops@gmail.com>
@openshift-ci
openshift-ci Bot requested review from kim-tsao and rm3l October 1, 2026 11:49
@sonarqubecloud

sonarqubecloud Bot commented Oct 1, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@openshift-ci

openshift-ci Bot commented Oct 1, 2026

Copy link
Copy Markdown

@jonkoops: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm 49d58df link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.77%. Comparing base (45d1b12) to head (49d58df).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5572      +/-   ##
==========================================
- Coverage   72.40%   65.77%   -6.63%     
==========================================
  Files          68       61       -7     
  Lines         790      637     -153     
  Branches      113       96      -17     
==========================================
- Hits          572      419     -153     
  Misses        217      217              
  Partials        1        1              
Flag Coverage Δ
rhdh 65.77% <ø> (-6.63%) ⬇️
Components Coverage Δ
Backend plugins ∅ <ø> (∅)
Backend app 78.94% <ø> (ø)
Frontend app 57.43% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45d1b12...49d58df. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nickboldt
nickboldt merged commit 049671d into redhat-developer:main Oct 1, 2026
22 of 24 checks passed
@jonkoops
jonkoops deleted the chore/node-headers-v24.21.0 branch October 1, 2026 12:32
@jonkoops

jonkoops commented Oct 2, 2026

Copy link
Copy Markdown
Member Author

/cherrypick release-2.1

@openshift-cherrypick-robot

Copy link
Copy Markdown
Contributor

@jonkoops: new pull request created: #5577

Details

In response to this:

/cherrypick release-2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants