Skip to content

chore(intelligent-assistant): change intelligent assistant (lightspeed) configs repository - #305

Closed
michael-valdron wants to merge 1 commit into
redhat-developer:devfrom
michael-valdron:rhdh-intelligent-assistant-configs
Closed

chore(intelligent-assistant): change intelligent assistant (lightspeed) configs repository#305
michael-valdron wants to merge 1 commit into
redhat-developer:devfrom
michael-valdron:rhdh-intelligent-assistant-configs

Conversation

@michael-valdron

@michael-valdron michael-valdron commented Sep 3, 2026

Copy link
Copy Markdown
Member

Target branch

  • dev: all development work (features, docs, dependency updates, etc.)

  • I have verified this PR targets the correct branch (see branching strategy)

Description

We have migrated redhat-ai-dev/lightspeed-configs to redhat-developer/rhdh-intelligent-assistant-configs for all upcoming feature releases of RHDH. Starting with RHDH 2.1, the intelligent assistant (lightspeed) configs will be fetched from redhat-developer/rhdh-intelligent-assistant-configs.

Note: redhat-ai-dev/lightspeed-configs will be kept active for RHDH 1.10 support, do not backport this change.

Which issue(s) does this PR fix or relate to

https://redhat.atlassian.net/browse/RHIDP-14891 (Developer Week)

https://redhat.atlassian.net/browse/RHIDP-16898

PR acceptance criteria

  • Tests updated and passing
  • Documentation updated
  • Built-in TechDocs updated if needed. Note that TechDocs changes may need to be reviewed by a Product Manager and/or Architect to ensure content accuracy, clarity, and alignment with user needs.

How to test changes / Special notes to the reviewer

Run bash hack/sync-lightspeed-configs.sh to test syncing the content. Changes from this script are not part of this PR's scope however.

@michael-valdron
michael-valdron force-pushed the rhdh-intelligent-assistant-configs branch 2 times, most recently from e676886 to 47f7cf4 Compare September 3, 2026 17:12
@michael-valdron
michael-valdron marked this pull request as ready for review September 3, 2026 17:13
@rhdh-qodo-merge

Copy link
Copy Markdown
Contributor

PR Summary by Qodo

Route Lightspeed config sync to the new upstream repository

⚙️ Configuration changes 📝 Documentation 🕐 10-20 Minutes

Grey Divider

AI Description

• Routes RHDH 1.10 syncs to the legacy Lightspeed configuration repository.
• Moves newer release defaults to the Intelligent Assistant configuration repository.
• Aligns maintainer documentation and generated sync PR metadata with each upstream source.
Diagram

graph TD
  Workflow["Nightly workflow"] --> Branch{"Release 1.10?"} -->|Yes| Legacy["Legacy repository"] --> Script["Sync script"] --> Configs["Vendored configs"] --> PullRequest["Sync pull request"]
  Branch -->|No| NewRepo["Assistant repository"] --> Script
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Repository-aware workflow matrix
  • ➕ Keeps branch and repository selection in one declarative location
  • ➕ Avoids duplicating repository identifiers across workflow logic and script defaults
  • ➕ Makes future release additions explicit and reviewable
  • ➖ Couples the workflow matrix more closely to upstream repository policy
  • ➖ Still requires a sensible script default for manual use

Recommendation: Preserving the legacy source specifically for RHDH 1.10 is the correct compatibility strategy. A repository-aware workflow matrix would provide a clearer single source of truth as more release branches are added. Before merging, also reconcile the introduced redhat-dev/rhdh-intelligent-assistant-configs script and documentation value with the PR’s stated redhat-developer/rhdh-intelligent-assistant-configs destination.

Files changed (3) +14 / -4

Documentation (1) +1 / -1
maintaining-intelligent-assistant.mdDocument the new Lightspeed configuration source +1/-1

Document the new Lightspeed configuration source

• Replaces the legacy upstream repository reference with the new Intelligent Assistant configuration repository in the maintainer synchronization guide.

docs/intelligent-assistant/maintaining-intelligent-assistant.md

Other (2) +13 / -3
sync-lightspeed-configs.yamlRoute sync jobs to release-specific upstream repositories +12/-2

Route sync jobs to release-specific upstream repositories

• Adds explicit legacy repository routing for 'release-1.10' while allowing other branches to use the script’s new default. Generated pull-request metadata now identifies the selected upstream repository dynamically.

.github/workflows/sync-lightspeed-configs.yaml

sync-lightspeed-configs.shChange the default Lightspeed configuration repository +1/-1

Change the default Lightspeed configuration repository

• Changes the synchronization script’s default upstream from 'redhat-ai-dev/lightspeed-configs' to 'redhat-dev/rhdh-intelligent-assistant-configs'. Explicit '--repo' overrides remain supported for legacy releases and forks.

scripts/sync-lightspeed-configs.sh

@rhdh-qodo-merge

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 🔗 Cross-repo conflicts (2) 📜 Skill insights (0)

Grey Divider


Action required

1. Wrong upstream repository owner 🔗 Cross-repo conflict ≡ Correctness
Description
The default sync source is redhat-dev/rhdh-intelligent-assistant-configs instead of the intended
redhat-developer/rhdh-intelligent-assistant-configs, so default and future non-1.10 syncs fail
before updating the Lightspeed files mounted into RHDH. Because the documentation repeats the
incorrect owner, rhdh-local is blocked from consuming current upstream configuration for the RHDH
Lightspeed component, even though the workflow's TARGET_REPO identifies the intended repository.
Code

scripts/sync-lightspeed-configs.sh[5]

+DEFAULT_REPO="redhat-dev/rhdh-intelligent-assistant-configs"
Relevance

●●● Strong

The default repository owner conflicts with the intended upstream and workflow target, causing
default sync failures.

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The script assigns the incorrect default to repo, interpolates it into every raw GitHub download
URL, and exits when those fetches fail; the documented default command invokes that value without an
override. The workflow independently identifies
redhat-developer/rhdh-intelligent-assistant-configs as its target, while RHDH identifies
redhat-developer as its GitHub organization and Lightspeed as an upstream-managed component,
demonstrating that the script and documentation use an inconsistent owner.

scripts/sync-lightspeed-configs.sh[5-13]
scripts/sync-lightspeed-configs.sh[34-37]
scripts/sync-lightspeed-configs.sh[106-112]
.github/workflows/sync-lightspeed-configs.yaml[63-70]
docs/intelligent-assistant/maintaining-intelligent-assistant.md[46-53]
scripts/sync-lightspeed-configs.sh[5-5]
scripts/sync-lightspeed-configs.sh[58-59]
.github/workflows/sync-lightspeed-configs.yaml[66-70]
docs/intelligent-assistant/maintaining-intelligent-assistant.md[48-53]
External repo: redhat-developer/rhdh, docs/e2e-tests/CI-medic-guide.md [144-150]
External repo: redhat-developer/rhdh, docs/testing-requirements-matrix.md [221-227]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The default Lightspeed/intelligent-assistant configuration repository uses the incorrect `redhat-dev` organization, causing default and future non-1.10 sync commands to generate raw GitHub URLs for the wrong upstream location and fail before updating the files mounted into RHDH.

## Issue Context
The intended repository is `redhat-developer/rhdh-intelligent-assistant-configs`, as identified by the workflow metadata. The maintenance documentation repeats the script's incorrect owner and invokes the default without an override, so update both the executable configuration and user-facing documentation consistently.

## Fix Focus Areas
- scripts/sync-lightspeed-configs.sh[5-5]
- docs/intelligent-assistant/maintaining-intelligent-assistant.md[46-52]
- .github/workflows/sync-lightspeed-configs.yaml[63-70]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Remediation recommended

2. Generated repository link broken 🐞 Bug ≡ Correctness
Description
The generated PR body uses an owner/name string directly as a Markdown URL, so GitHub resolves it
relative to the PR page rather than linking to the upstream repository. This affects both the legacy
and new TARGET_REPO values.
Code

.github/workflows/sync-lightspeed-configs.yaml[90]

+          Automated nightly sync of Lightspeed config files from [${TARGET_REPO}](${TARGET_REPO}).
Relevance

●●● Strong

The owner/name value is not a valid absolute Markdown URL; correcting it is a deterministic
documentation fix.

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
Both possible TARGET_REPO values contain only owner/name, and line 90 uses that value directly
as the Markdown destination without a URL scheme or GitHub host.

.github/workflows/sync-lightspeed-configs.yaml[66-70]
.github/workflows/sync-lightspeed-configs.yaml[89-90]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The sync PR body constructs a relative Markdown link from an owner/name repository identifier.

## Issue Context
Keep `TARGET_REPO` as an owner/name value for display, but prefix the link destination with `https://github.com/`.

## Fix Focus Areas
- .github/workflows/sync-lightspeed-configs.yaml[66-70]
- .github/workflows/sync-lightspeed-configs.yaml[89-90]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


3. New sync path unreachable 🔗 Cross-repo conflict ☼ Reliability
Description
The workflow's only matrix entry is release-1.10, and the new conditional always routes that
branch to the legacy redhat-ai-dev/lightspeed-configs repository, leaving the new repository path
unreachable. Consequently, scheduled and manually dispatched runs never sync main, newer RHDH
release branches, or other active development targets from
redhat-developer/rhdh-intelligent-assistant-configs.
Code

.github/workflows/sync-lightspeed-configs.yaml[R41-44]

+          if [[ "${{ matrix.branch }}" == "release-1.10" ]]; then
+            ./scripts/sync-lightspeed-configs.sh --repo redhat-ai-dev/lightspeed-configs --ref ${{ matrix.branch }}
+          else
+            ./scripts/sync-lightspeed-configs.sh --ref ${{ matrix.branch }}
Relevance

●●● Strong

Accepted matrix coverage and branch-targeting fixes are established team expectations for workflows.

PR-#180

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The matrix defines only release-1.10, and checkout, synchronization, and PR targeting all derive
from that value; because the conditional explicitly routes it to the legacy repository, every
invocation takes the override and the else path for the new repository is never executed. RHDH
documents main as an active Core nightly branch and treats Lightspeed as an upstream-managed
component, demonstrating that current development receives no corresponding automated configuration
update.

.github/workflows/sync-lightspeed-configs.yaml[13-18]
.github/workflows/sync-lightspeed-configs.yaml[39-45]
.github/workflows/sync-lightspeed-configs.yaml[63-70]
.github/workflows/sync-lightspeed-configs.yaml[13-17]
.github/workflows/sync-lightspeed-configs.yaml[28-32]
.github/workflows/sync-lightspeed-configs.yaml[58-70]
External repo: redhat-developer/rhdh, docs/e2e-tests/CI-medic-guide.md [144-160]
External repo: redhat-developer/rhdh, docs/testing-requirements-matrix.md [221-227]
PR-#180

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The workflow's new-repository path is unreachable because the matrix contains only `release-1.10`, which is explicitly routed to the legacy `redhat-ai-dev/lightspeed-configs` repository. As a result, scheduled and manually dispatched runs do not sync active development or newer supported release branches from `redhat-developer/rhdh-intelligent-assistant-configs`.

## Issue Context
Keep the `release-1.10` legacy sync, but add matrix jobs for `main` and appropriate supported upcoming/new-release targets so the new repository path is exercised. Map each local RHDH target to a valid ref in `redhat-developer/rhdh-intelligent-assistant-configs` rather than assuming the local target branch and upstream configuration branch always have identical names.

## Fix Focus Areas
- .github/workflows/sync-lightspeed-configs.yaml[13-18]
- .github/workflows/sync-lightspeed-configs.yaml[39-45]
- .github/workflows/sync-lightspeed-configs.yaml[58-70]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Context sources
⚠️ Tickets: not configured — ticket URL found in PR but could not be fetched — check ticket provider credentials
✅ Cross-repo context — repo relationships
  Explored: repo: redhat-developer/rhdh (sha: 506c86ab)

Grey Divider

Tip of the day
💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@rhdh-qodo-merge rhdh-qodo-merge Bot added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 3, 2026
@michael-valdron michael-valdron changed the title Rhdh intelligent assistant configs chore(intelligent-assistant): change intelligent assistant (lightspeed) configs repository Sep 3, 2026
@michael-valdron
michael-valdron force-pushed the rhdh-intelligent-assistant-configs branch from 47f7cf4 to 754eb67 Compare September 3, 2026 17:19
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
michael-valdron force-pushed the rhdh-intelligent-assistant-configs branch from 754eb67 to 2ae0da6 Compare September 3, 2026 17:20
@sonarqubecloud

sonarqubecloud Bot commented Sep 3, 2026

Copy link
Copy Markdown

@michael-valdron

Copy link
Copy Markdown
Member Author

Moved to #322 to remove any possible artifacts when re-targeting to dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant