Skip to content

Port kuttl 1-113 validate controller role test to Ginkgo#1214

Open
Naveena-058 wants to merge 1 commit into
redhat-developer:masterfrom
Naveena-058:port-1-113_validate_controller_role
Open

Port kuttl 1-113 validate controller role test to Ginkgo#1214
Naveena-058 wants to merge 1 commit into
redhat-developer:masterfrom
Naveena-058:port-1-113_validate_controller_role

Conversation

@Naveena-058

@Naveena-058 Naveena-058 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind enhancement

What does this PR do / why we need it:
Ports the kuttl sequential test 1-113_validate_controller_role from operator-e2e to a Ginkgo sequential e2e test.

The test verifies that when a namespace is managed by openshift-gitops, the openshift-gitops-argocd-application-controller Role is created and correctly aggregates rules from ClusterRoles labeled rbac.authorization.k8s.io/aggregate-to-admin, then removes those rules when the ClusterRole is deleted.

LOGS -
Local execution of 1-113 ginkgo test.txt

Signed-off-by: NAVEENA S <nas@redhat.com>
@openshift-ci openshift-ci Bot added the kind/enhancement New feature or request label Jul 13, 2026
@openshift-ci openshift-ci Bot requested review from anandrkskd and svghadi July 13, 2026 07:55
@openshift-ci

openshift-ci Bot commented Jul 13, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign varshab1210 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a sequential Ginkgo E2E test that verifies an aggregated ClusterRole rule appears in, and is removed from, the OpenShift GitOps application-controller Role.

Changes

RBAC aggregation validation

Layer / File(s) Summary
Controller Role aggregation E2E test
test/openshift/e2e/ginkgo/sequential/1-113_validate_controller_role_test.go
Creates the managed namespace and aggregate ClusterRole, verifies policy-rule aggregation into the application-controller Role, confirms rule removal after deletion, and performs cleanup with failure debugging.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the main change: porting the 1-113 controller role test to Ginkgo.
Description check ✅ Passed The description is directly related to the changeset and accurately explains the Ginkgo test port.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Naveena-058

Copy link
Copy Markdown
Contributor Author

/test v4.19-ci-index-gitops-operator-bundle

@openshift-ci

openshift-ci Bot commented Jul 13, 2026

Copy link
Copy Markdown

@Naveena-058: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.19-e2e ef2d6ec link true /test v4.19-e2e
ci/prow/v4.19-images ef2d6ec link true /test v4.19-images
ci/prow/v4.19-kuttl-sequential ef2d6ec link true /test v4.19-kuttl-sequential
ci/prow/v4.19-kuttl-parallel ef2d6ec link true /test v4.19-kuttl-parallel
ci/prow/v4.14-e2e ef2d6ec link false /test v4.14-e2e
ci/prow/v4.14-kuttl-parallel ef2d6ec link false /test v4.14-kuttl-parallel
ci/prow/v4.14-kuttl-sequential ef2d6ec link false /test v4.14-kuttl-sequential
ci/prow/v4.14-images ef2d6ec link true /test v4.14-images
ci/prow/v4.19-ci-index-gitops-operator-bundle ef2d6ec link true /test v4.19-ci-index-gitops-operator-bundle
ci/prow/v4.14-ci-index-gitops-operator-bundle ef2d6ec link true /test v4.14-ci-index-gitops-operator-bundle

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants