Merge pull request #1372 from mohitsuman/gh-1371

Add close button to final page

Author: mohitsuman

browser/app.css

@@ -661,10 +661,6 @@ footer {
     border-radius: 1px;
   }
 
-  #exit-btn {
-    margin-top: 1%;
-  }
-
   .progress-description {
     max-width: 100%;
   }
@@ -1045,4 +1041,19 @@ footer {
   .startForm {
     padding-top: 2%;
   }
+
+  .success-message{
+    border-width: 0px;
+    border-color: white;
+    background-color: white;
+    margin-bottom: 3px;
+    margin-top: -5px;
+  }
+
+  .btn-close {
+    padding: 6px 10px;
+    line-height: 1.33;
+    border-radius: 1px;
+    text-transform: uppercase;
+  }
 }

browser/pages/start/start.html

@@ -2,9 +2,12 @@
 <main>
   <div class="col-sm-12 bottom-spacer" style="margin-top:20px;">
     <div class="container-fluid container-cards-pf">
-      <div class="alert alert-success">
+      <div class="alert alert-success success-message col-sm-10">
         <span class="pficon pficon-ok"></span>
-        <strong>Great job!!&nbsp;</strong><span id="install-alert">Everything's installed and you're good to go!</span>
+        <span id="install-alert">Great job!! All components installed. Click on <b>Get Started</b> to proceed.</span>
+      </div>
+      <div>
+        <button type="button" class="btn btn-default btn-close pull-right" id="exit-btn" ng-click="startCtrl.exit()">Close installer</button>
       </div>
       <get-started component="'devstudio'" start="startCtrl.startDevstudio()"></get-started>
       <get-started component="'cdk'" start="startCtrl.startCdk()"></get-started>

test/ui/start-test.js

@@ -4,26 +4,20 @@ let context = { pageName: 'Get Started' };
 let breadcrumbBase = require('./breadcrumbs-base');
 
 describe('Getting Started Page', function() {
-  let devstudioButton, closeButton, quickstartLink, installAlert;
+  let closeButton, installAlert;
 
   beforeAll(function() {
     browser.setLocation('start')
       .then(function() {
-        // devstudioButton = element(By.id('start-submit'));
-        // closeButton = element(By.id('exit-btn'));
+        closeButton = element(By.id('exit-btn'));
         installAlert = element(By.id('install-alert'));
       });
   });
 
-  // it('should display a button to start devstudio', function() {
-  //   expect(devstudioButton.isDisplayed()).toBe(true);
-  //   expect(devstudioButton.isEnabled()).toBe(true);
-  // });
-
-  // it('should display a button to close the installer', function() {
-  //   expect(closeButton.isDisplayed()).toBe(true);
-  //   expect(closeButton.isEnabled()).toBe(true);
-  // });
+  it('should display a button to close the installer', function() {
+    expect(closeButton.isDisplayed()).toBe(true);
+    expect(closeButton.isEnabled()).toBe(true);
+  });
 
   it('should display a alert to a mention if successfull installation', function() {
     expect(installAlert.isDisplayed()).toBe(true);