Skip to content

Commit 84a26e8

Browse files
committed
Add close button to final page
1 parent b70b8a8 commit 84a26e8

3 files changed

Lines changed: 26 additions & 18 deletions

File tree

browser/app.css

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -661,10 +661,6 @@ footer {
661661
border-radius: 1px;
662662
}
663663

664-
#exit-btn {
665-
margin-top: 1%;
666-
}
667-
668664
.progress-description {
669665
max-width: 100%;
670666
}
@@ -1045,4 +1041,19 @@ footer {
10451041
.startForm {
10461042
padding-top: 2%;
10471043
}
1044+
1045+
.success-message{
1046+
border-width: 0px;
1047+
border-color: white;
1048+
background-color: white;
1049+
margin-bottom: 3px;
1050+
margin-top: -5px;
1051+
}
1052+
1053+
.btn-close {
1054+
padding: 6px 10px;
1055+
line-height: 1.33;
1056+
border-radius: 1px;
1057+
text-transform: uppercase;
1058+
}
10481059
}

browser/pages/start/start.html

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,12 @@
22
<main>
33
<div class="col-sm-12 bottom-spacer" style="margin-top:20px;">
44
<div class="container-fluid container-cards-pf">
5-
<div class="alert alert-success">
5+
<div class="alert alert-success success-message col-sm-10">
66
<span class="pficon pficon-ok"></span>
7-
<strong>Great job!!&nbsp;</strong><span id="install-alert">Everything's installed and you're good to go!</span>
7+
<span id="install-alert">Great job!! All components installed. Click on <b>Get Started</b> to proceed.</span>
8+
</div>
9+
<div>
10+
<button type="button" class="btn btn-default btn-close pull-right" id="exit-btn" ng-click="startCtrl.exit()">Close installer</button>
811
</div>
912
<get-started component="'devstudio'" start="startCtrl.startDevstudio()"></get-started>
1013
<get-started component="'cdk'" start="startCtrl.startCdk()"></get-started>

test/ui/start-test.js

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,26 +4,20 @@ let context = { pageName: 'Get Started' };
44
let breadcrumbBase = require('./breadcrumbs-base');
55

66
describe('Getting Started Page', function() {
7-
let devstudioButton, closeButton, quickstartLink, installAlert;
7+
let closeButton, installAlert;
88

99
beforeAll(function() {
1010
browser.setLocation('start')
1111
.then(function() {
12-
// devstudioButton = element(By.id('start-submit'));
13-
// closeButton = element(By.id('exit-btn'));
12+
closeButton = element(By.id('exit-btn'));
1413
installAlert = element(By.id('install-alert'));
1514
});
1615
});
1716

18-
// it('should display a button to start devstudio', function() {
19-
// expect(devstudioButton.isDisplayed()).toBe(true);
20-
// expect(devstudioButton.isEnabled()).toBe(true);
21-
// });
22-
23-
// it('should display a button to close the installer', function() {
24-
// expect(closeButton.isDisplayed()).toBe(true);
25-
// expect(closeButton.isEnabled()).toBe(true);
26-
// });
17+
it('should display a button to close the installer', function() {
18+
expect(closeButton.isDisplayed()).toBe(true);
19+
expect(closeButton.isEnabled()).toBe(true);
20+
});
2721

2822
it('should display a alert to a mention if successfull installation', function() {
2923
expect(installAlert.isDisplayed()).toBe(true);

0 commit comments

Comments
 (0)