Repository navigation
deps: force tinypool 2.1.2 to fix critical alerts (M12) - #285
Merged
Merged
Conversation
ben-harris-5
approved these changes
Nov 11, 2026
RGood
added a commit
that referenced
this pull request
Nov 11, 2026
) ## Summary Fixes two open Dependabot alerts in `devvit-docs` (M12) without any `resolutions` override. Only changes that fix an open alert are included. | Change | Alert | Risk | |---|---|---| | Refresh the lockfile entry for `@redocly/openapi-core` (1.34.19 → 1.34.24, same `^1.4.0` range) | #107 (high) | Patch bump | | `fast-xml-parser` 5.11.1 → 5.12.0 (from Dependabot #280) | #160 (low) | Minor bump | ## Details - `@redocly/openapi-core` 1.34.19 pinned `js-yaml` to exactly `4.3.1`. Every release from 1.34.20 onward depends on `js-yaml` 4.3.2 (latest 1.x is 1.34.24). The lockfile was simply stuck on 1.34.19, so `yarn up -R @redocly/openapi-core` resolves the fix inside the existing range. `package.json` is unchanged. - This replaces an earlier version of this PR that forced `js-yaml@npm:4.3.1` to 4.3.2 through `resolutions`; thanks @ben-harris-5 for pushing for the cleaner fix. The override has been removed (`package.json` is identical to `main`). - Result: one `js-yaml` entry (4.3.2) used by all 10 dependents. - #280 is merged in unchanged. `fast-xml-parser` 5.12.0 also updates its own dependencies within their ranges (`@nodable/entities`, `fast-xml-builder`, `is-unsafe`, `strnum`). - Dependabot #267 (`js-yaml` 5.5.0, a major bump) is not needed for the alert. - Verified locally with the repo's pinned Yarn 4.18.0: `yarn install --immutable` passes. ## Testing CI `build` should pass. After merge, confirm the Pages deploy succeeds and that #107 and #160 close. ## Not included (separate) - `tinypool` critical alerts #137/#138: see #285. - Major-version Dependabot bumps and PRs that fix no alert. Part of M12 (fix dependency alerts). --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the two critical
tinypoolalerts (#137 and #138, M12) by forcingtinypool1.1.1 to 2.1.2 with aresolutionsentry. This is a major-version override of a transitive dependency, so it is a separate PR from the low-risk dependency fixes and can be reverted on its own.Background
@docusaurus/core3.10.2 depends ontinypool ^1.0.2. The advisories are fixed in 2.1.1 / 2.1.2.tinypool2 is4.0.0-canary-*, which is not stable, so the override is the way to close the alerts on Docusaurus 3.tinypoolis a build-time worker pool (used by Docusaurus' static site generation). It is not part of the published site.Change
package.json: add"tinypool@npm:^1.0.2": "npm:2.1.2"toresolutions.yarn.lockupdated accordingly (onlytinypoolchanges).Verification (local, with the repo's pinned Yarn 4.18.0)
yarn install --immutablepasses.tinypool2.1.2 supports Node 24 (^20 || >=22); it has no dependencies; the default export Docusaurus imports (import('tinypool').then(m => m.default)) is still present.yarn buildsucceeds, with the same warnings asmain(5 HTML minifier diagnostics, 2 broken anchors).main: same 11,610 files. All 3,785 HTML pages are identical after normalizing content hashes. The differences are theruntime~mainbundle (same size and same code, different minifier variable names) and the section order inllms-full.txt(same lines, same headings). Two separate builds ofmainalso differ inllms-full.txtorder, so that variation is not caused by this change.Testing
CI
buildshould pass. After merge, confirm the Pages deploy succeeds and that #137 and #138 close.Risk / rollback
Low-moderate: a major bump of a build tool. If the build or deploy misbehaves, revert this single commit.
Part of M12 (fix dependency alerts).