Skip to content

deps: force tinypool 2.1.2 to fix critical alerts (M12) - #285

Merged
RGood merged 1 commit into
mainfrom
deps/m12-tinypool-override
Nov 11, 2026
Merged

RGood merged 1 commit into
mainfrom
deps/m12-tinypool-override

Conversation

@RGood

@RGood RGood commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes the two critical tinypool alerts (#137 and #138, M12) by forcing tinypool 1.1.1 to 2.1.2 with a resolutions entry. This is a major-version override of a transitive dependency, so it is a separate PR from the low-risk dependency fixes and can be reverted on its own.

Background

  • @docusaurus/core 3.10.2 depends on tinypool ^1.0.2. The advisories are fixed in 2.1.1 / 2.1.2.
  • The only Docusaurus line that depends on tinypool 2 is 4.0.0-canary-*, which is not stable, so the override is the way to close the alerts on Docusaurus 3.
  • tinypool is a build-time worker pool (used by Docusaurus' static site generation). It is not part of the published site.

Change

package.json: add "tinypool@npm:^1.0.2": "npm:2.1.2" to resolutions. yarn.lock updated accordingly (only tinypool changes).

Verification (local, with the repo's pinned Yarn 4.18.0)

  • yarn install --immutable passes.
  • tinypool 2.1.2 supports Node 24 (^20 || >=22); it has no dependencies; the default export Docusaurus imports (import('tinypool').then(m => m.default)) is still present.
  • Full yarn build succeeds, with the same warnings as main (5 HTML minifier diagnostics, 2 broken anchors).
  • Compared the built site against a build of current main: same 11,610 files. All 3,785 HTML pages are identical after normalizing content hashes. The differences are the runtime~main bundle (same size and same code, different minifier variable names) and the section order in llms-full.txt (same lines, same headings). Two separate builds of main also differ in llms-full.txt order, so that variation is not caused by this change.

Testing

CI build should pass. After merge, confirm the Pages deploy succeeds and that #137 and #138 close.

Risk / rollback

Low-moderate: a major bump of a build tool. If the build or deploy misbehaves, revert this single commit.

Part of M12 (fix dependency alerts).

@RGood
RGood requested review from a team and ben-harris-5 November 11, 2026 18:05
@RGood
RGood merged commit 6fc275f into main Nov 11, 2026
5 checks passed
@RGood
RGood deleted the deps/m12-tinypool-override branch November 11, 2026 18:13
RGood added a commit that referenced this pull request Nov 11, 2026
)

## Summary
Fixes two open Dependabot alerts in `devvit-docs` (M12) without any
`resolutions` override. Only changes that fix an open alert are
included.

| Change | Alert | Risk |
|---|---|---|
| Refresh the lockfile entry for `@redocly/openapi-core` (1.34.19 →
1.34.24, same `^1.4.0` range) | #107 (high) | Patch bump |
| `fast-xml-parser` 5.11.1 → 5.12.0 (from Dependabot #280) | #160 (low)
| Minor bump |

## Details
- `@redocly/openapi-core` 1.34.19 pinned `js-yaml` to exactly `4.3.1`.
Every release from 1.34.20 onward depends on `js-yaml` 4.3.2 (latest 1.x
is 1.34.24). The lockfile was simply stuck on 1.34.19, so `yarn up -R
@redocly/openapi-core` resolves the fix inside the existing range.
`package.json` is unchanged.
- This replaces an earlier version of this PR that forced
`js-yaml@npm:4.3.1` to 4.3.2 through `resolutions`; thanks @ben-harris-5
for pushing for the cleaner fix. The override has been removed
(`package.json` is identical to `main`).
- Result: one `js-yaml` entry (4.3.2) used by all 10 dependents.
- #280 is merged in unchanged. `fast-xml-parser` 5.12.0 also updates its
own dependencies within their ranges (`@nodable/entities`,
`fast-xml-builder`, `is-unsafe`, `strnum`).
- Dependabot #267 (`js-yaml` 5.5.0, a major bump) is not needed for the
alert.
- Verified locally with the repo's pinned Yarn 4.18.0: `yarn install
--immutable` passes.

## Testing
CI `build` should pass. After merge, confirm the Pages deploy succeeds
and that #107 and #160 close.

## Not included (separate)
- `tinypool` critical alerts #137/#138: see #285.
- Major-version Dependabot bumps and PRs that fix no alert.

Part of M12 (fix dependency alerts).

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants