Repository navigation
Prevent stale Thrift results from masking successful retries - #724
Closed
ianvkoeppe wants to merge 2 commits into
Closed
ianvkoeppe wants to merge 2 commits into
ianvkoeppe wants to merge 2 commits into
Conversation
kevinjonaitis-dot
self-requested a review
September 30, 2026 19:02
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
A retryable IDL exception followed by a successful response must return success. Thrift decoding leaves fields absent from the wire untouched, so the retry middleware clears generated result state before subsequent attempts. The first attempt, retry policy, middleware order, and final failure state retain their contracts.
Validation
The Thrift package tests pass with the race detector. Regression cases cover an exception followed by success, partial transport responses, final and terminal exceptions, and nil oneway results. CI pending.