Skip to content

Prevent stale Thrift results from masking successful retries - #724

Closed
ianvkoeppe wants to merge 2 commits into
masterfrom
fix-thrift-retry-result-lifecycle
Closed

ianvkoeppe wants to merge 2 commits into
masterfrom
fix-thrift-retry-result-lifecycle

Conversation

@ianvkoeppe

Copy link
Copy Markdown
Contributor

Intent

A retryable IDL exception followed by a successful response must return success. Thrift decoding leaves fields absent from the wire untouched, so the retry middleware clears generated result state before subsequent attempts. The first attempt, retry policy, middleware order, and final failure state retain their contracts.

Validation

The Thrift package tests pass with the race detector. Regression cases cover an exception followed by success, partial transport responses, final and terminal exceptions, and nil oneway results. CI pending.

@kevinjonaitis-dot kevinjonaitis-dot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖/🧑‍🦱 LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants