refactor!: replace the COMPLEX_PERM_* extension points with a direct call - #6689
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ComplexPermission::removeItem()andreplaceItem()dispatched the extension pointsCOMPLEX_PERM_REMOVE_ITEM/COMPLEX_PERM_REPLACE_ITEM, whose only listener wasUserRolein the core itself. The indirection bought nothing, so both methods now callUserRole::replaceComplexPermItem()directly.Breaking
COMPLEX_PERM_REMOVE_ITEMandCOMPLEX_PERM_REPLACE_ITEMare removed.ComplexPermission::removeItem()/replaceItem()stay the public API for cleaning up role permissions.Also
UserRoleTest, the replace/remove logic had no test coverage before.