refactor!: remove the addon properties - #6687
Merged
Merged
Conversation
The property bag was a REDAXO 5 idiom: an `install.php` set values that core picked up later. In 6.x the addon hooks are typed and composer.json supplies the metadata, so nothing wrote to it any more. Its only reader was the `successmsg` in `AddonManager::install()`, which no longer fits either: `install()` is idempotent and runs on every `migrate`, so a message meant for a one-time installation would reappear on every deploy. An addon that needs to abort still throws a `UserMessageException`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6684.
Addon::setProperty(),getProperty(),hasProperty()andremoveProperty()plus the backing array are gone.The bag was a REDAXO 5 idiom: an
install.phpstashed values there and core picked them up later. In 6.x the addon hooks are typed and the metadata accessors (getAuthor(),getVersion(),getSupportPage(),getLicense()) read from composer.json /InstalledVersions, so nothing wrote to the bag any more — a grep over core, both addons and the project skeleton finds no writer.Its only reader was
successmsginAddonManager::install(), removed along with it. That one does not fit 6.x regardless of the bag:install()is idempotent by contract and runs on everymigrate, so a message meant for a one-time installation would reappear on every deploy. An addon that needs to abort an install still throws aUserMessageException.No baseline changes.
composer checkis green, andconsole migratestill reports all four packages as OK.