Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assistant messages carrying both
reasoningandreasoning_contentcurrently return HTTP 400. Normalize them once, giving the publicreasoningfield precedence by presence, including empty/null values. This avoids concatenating duplicate thoughts when clients replay responses.Fixes #46.
Validation: 38 focused Python tests passed across serving, Anthropic translation and chat; Ruff and whitespace checks passed. Coverage includes equal/different aliases, either field alone, empty/null precedence, and streaming/nonstreaming responses. No real model inference or Hermes session was run.