Repository navigation
Support for oh-my-pi (omp) as a harness with rec launch omp - #47
Open
daniel-sali wants to merge 3 commits into
Open
daniel-sali wants to merge 3 commits into
daniel-sali wants to merge 3 commits into
Conversation
strin
suggested changes
Nov 5, 2026
strin
left a comment
strin
left a comment
There was a problem hiding this comment.
Thanks for adding omp. Isolated config/session handling, environment-based key delivery and a locked fallback install are useful. Seven targeted Go tests passed with the race detector; go vet ./... passed.
Before merge:
- The launcher prefers an arbitrary omp on PATH, while README says harnesses are separate from existing installs. Either always use the pinned install or document PATH preference and the supported-version policy accurately.
- Stub/string tests do not establish wire compatibility with the pinned package. Please add or record an isolated fake-server qualification of streamed tool calls, auth, context/max-token settings and a second-turn assistant replay using that version. No real model/customer prompts are needed.
I reviewed the lockfile but did not install/run the package; stub tests are not end-to-end harness validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
rec launch ompcommand, which starts anompsession with Flint pre-configured properly as the model to use, with correct message size and tool calling configurations.