Repository navigation
Fix privatize-constants on typed constants - #161
Merged
Merged
Conversation
Regex didn't allow a type between 'const' and the name, so typed constants like 'public const string FOO' were reported as changed but left untouched. Match the optional type and keep it in the replacement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #160
The visibility regex matched
const NAMEdirectly, so a type betweenconstand the name (public const string FOO) never matched. The constant was reported as "changed to private" but the file was left untouched.Now the regex matches an optional type and keeps it in the replacement:
public const string FOO->private const string FOOpublic const BAR->private const BARAdded a command test covering both typed and untyped constants.