Repository navigation
Conversation
Signed-off-by: mairo744 <mairo744@gmail.com>
Comment on lines
+37
to
+48
| protected function tearDown(): void | ||
| { | ||
| chdir($this->originalWorkingDirectory); | ||
|
|
||
| unlink($this->entityFilePath); | ||
| rmdir(dirname($this->entityFilePath)); | ||
| rmdir($this->projectDirectory . '/src'); | ||
| @unlink($this->projectDirectory . '/composer.json'); | ||
| rmdir($this->projectDirectory); | ||
|
|
||
| parent::tearDown(); | ||
| } |
Member
There was a problem hiding this comment.
Can you update test to simply return list of classes to be finalized and verify that?
I want to avoid e2e testing if possible, as this gets messy.
Author
There was a problem hiding this comment.
I would extract public method that returns the files to finalize without writing them, and test that. Does that work for you?
Signed-off-by: mairo744 <mairo744@gmail.com>
Signed-off-by: mairo744 <mairo744@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#157
Allow
finalize-classesto finalize Doctrine entities when the project meets the required PHP and Doctrine ORM version constraints.