Repository navigation
Invalid downgrade code for DowngradeArraySpreadRector on use property + variable same name with different type #9951
Description
Bug Report
| Subject | Details |
|---|---|
| Rector version | e.g. dev-main (invoke vendor/bin/rector --version) |
Minimal PHP Code Causing Issue
Given the following code:
namespace App;
use ArrayIterator;
final class PropertySameNameAsVariable
{
public ArrayIterator $items;
public function run()
{
$items = ['apple'];
return [...$this->items, ...$items];
}
}
$a = new PropertySameNameAsVariable();
$a->items = new ArrayIterator([]);
$a->run();It produce:
- return [...$this->items, ...$items];
+ return array_merge($this->items, $items);see demo page:
which invalid, as it will cause error on run, see
Expected Behaviour
- return [...$this->items, ...$items];
+ return array_merge(iterator_to_array($this->items), $items);
Activity
samsonasik commentedon Nov 1, 2026
I created PR
for it.
[-]Invalid downgrade code for DowngradeArraySpreadRector on use property + variable same name[/-][+]Invalid downgrade code for DowngradeArraySpreadRector on use property + variable same name with different type[/+]