Rector removes class imports that are specified only in inline tags `@see`

[mspirkov]

Bug Report

Subject	Details
Rector version	2.5.2

Rector removes class imports that are specified only in inline tags @see. This happens in @param, @var, @return, and in the description of a class, method, or property.

Minimal PHP Code Causing Issue

Demo: https://getrector.com/demo/8c0c0d34-ab18-4c07-b8d5-7e3a4cb97b65

Expected Behaviour

Class imports are not deleted.

[samsonasik]

That's due to removeUnusedImports enabled by default on 2.5, you can disable it for that case via withImportNames(removeUnusedImports: false):

see
https://getrector.com/demo/af5ac405-05a5-4001-986f-801139641281

[TomasVotruba]

@samsonasik We should fix this instead. Can you look into this?

Maybe the docblock should be updated to single @see, the provided one looks unsupported

@mspirkov use standard @see syntax to get covered https://getrector.com/demo/9858df7e-47b7-40bd-a85d-2cf8aa859874

[samsonasik]

{@see } is detected as text because of not a generic node, see my original comment on this issue

#9750 (comment)

[mspirkov]

For now, I plan to simply disable this behavior, as I have PHP CS Fixer enabled, which will handle this correctly.
This issue arose after the latest update, and I thought it would be appropriate to report it 🙂

[talha-core]

The issue look is like this, when running both php-cs-fixer and rector:

<?php

declare(strict_types=1);

namespace App\Entity;

use App\Repository\StorageTypeRepository;
use App\Tests\Entity\StorageTypeTest;
use Doctrine\ORM\Mapping as ORM;

/**
 * @see StorageTypeTest
 * @see \App\Tests\Entity\StorageTypeTest
 */
#[ORM\Entity(repositoryClass: StorageTypeRepository::class)]
class StorageType
{}

[samsonasik]

rectorphp/rector-src#8080