ReplaceArgumentDefaultValueRector - incorrect behavoir

[sreichel]

Bug Report

Subject	Details
Rector version	2.4.1
Rule	ReplaceArgumentDefaultValueRector

Minimal PHP Code Causing Issue

https://getrector.com/demo/ee3028f5-5037-4449-9329-5b2aa1da98aa

Expected Behaviour

See comments in demo.

---

Notes:

• ''testClass/replaceClass" works, but "self::" should be used
• "testSelf/replaceSelf" looks good, but test4 goes wrong! This causes errors, const does not exist.

<?php

class Super
{
    public const SORT_ORDER_ASC = 'ASC';

	public const SORT_ORDER_DESC = 'DESC';
}

class Test1 extends Super
{
    public function testClass(string $dir = self::SORT_ORDER_ASC)
    {
        $this->replaceClass(self::SORT_ORDER_ASC);
    }

    public function testSelf(string $dir = self::SORT_ORDER_ASC)
    {
        $this->replaceSelf(self::SORT_ORDER_ASC);
    }

}

class Test2 extends Super
{
    public function testClass(string $dir = self::SORT_ORDER_ASC)
    {
        $this->replaceClass(self::SORT_ORDER_ASC);
    }

    public function testSelf(string $dir = self::SORT_ORDER_ASC)
    {
        $this->replaceSelf(self::SORT_ORDER_ASC);
    }

}

class Test3 extends Super
{
    public function testClass(string $dir = self::SORT_ORDER_ASC)
    {
        $this->replaceClass(self::SORT_ORDER_ASC);
    }
    
    public function testSelf(string $dir = self::SORT_ORDER_ASC)
    {
        $this->replaceSelf(self::SORT_ORDER_ASC);
    }
}

class Test4
{
    public function testClass(string $dir = Super::SORT_ORDER_ASC)
    {
        $test = new Test3();
        $test->replaceClass(Super::SORT_ORDER_ASC);
    }

    public function testSelf(string $dir = Super::SORT_ORDER_ASC)
    {
        $test = new Test3();
        $test->replaceSelf(Super::SORT_ORDER_ASC);
    }
}

[TomasVotruba]

Fixed in rectorphp/rector-src#8023

Can you verify? If the problem still persists, please provide only single fixture class with demo + expected behavior. Let's take it one by one :) thank you