Incorrect behavior of UseIdenticalOverEqualWithSameTypeRector

[Payn]

Bug Report

Subject	Details
Rector version	2.3.2

Using PHPDoc annotations breaks this rule

Minimal PHP Code Causing Issue

https://getrector.com/demo/2dc5752b-4279-4a2e-a3d4-0bfe5a069fa4

Expected Behaviour

"==" should be replaced with "===" but it's not.
When you remove the annotations it works as expected (see https://getrector.com/demo/094eb16e-8cb1-4a94-84f0-62fd0214554b)

[Payn]

Real case in our codebase is actually a bit more complicated. I noticed it when using identical class getters with same return type when one of the variables holding class object has type annotation.
I can create demo for that as well if needed.

[Payn]

Here's a simplified version of what's happening in our case: https://getrector.com/demo/e86dd35d-099e-4daf-88e3-67ad46ac8c60
Seems like if any part of the expression is annotated, it disables this rule completely.

[samsonasik]

Thanks, we are currently dealing with issue on new phpstan 2.1.35:

• PHPStan 2.1.35 cause error on rector-downgrade-php phpstan/phpstan#13992

that PHPStan Virtual node no longer enter original node on processing node.

I will check after that sorted :)

[samsonasik]

This seems expected, everything that came from @var become follow as non-native type, to actually apply this, you need to remove useless @var for it.

I think RemoveUselessVarTagRector should support removing @var for assign expression when it actually an equal type with native type.

[Payn]

That sounds reasonable.

But here is our case recreated more closely: https://getrector.com/demo/1988ef2d-d651-4e76-ab2b-74e8f3426308
So in this case the annotation is also useless @var tag that should be removed?
My IDE can infer the type without annotation, seems like Rector can too as it works when you remove it.

[samsonasik]

Yes, for native type result, @var is not needed, let's do one by one at

• [DeadCode] Allow remove @var on expression assign on RemoveUselessVarTagRector rector-src#7871

[Payn]

@samsonasik i found another interesting case where this doesn't work: https://getrector.com/demo/917fe57c-b006-4e49-8600-36d40817a740
or even https://getrector.com/demo/d8891887-d190-4dfb-bb48-30fd2ca4760c

Here the @var is needed as the return type on create() is not specified.
But i guess this is manually overriding the native type as you said earlier, so Rector shouldn't do anything in this case right?

[samsonasik]

Let's do one by one, the RemoveUselessVarTagRector should allow to remove the useless @var so it can be use correct identical, if you found that PR:

• [DeadCode] Allow remove @var on expression assign on RemoveUselessVarTagRector rector-src#7871

is missing some use case, feel free to add more fixtures after the PR merged so can be covered later :)

[github-actions]

This issue has been automatically locked because it has been closed for 150 days. Please open a new issue if you have a similar problem.