Repository navigation
[TypeDeclarationDocblocks] Skip invalid @return tag to fix infinite loop in DocblockReturnArrayFromDirectArrayInstanceRector - #8918
Merged
Conversation
…ArrayFromDirectArrayInstanceRector to avoid infinite loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9959
An invalid docblock like
@return array'(trailing quote) parses to anInvalidTagValueNode, sogetReturnTagValue()returnsnull. The rule then falls into theelsebranch ofchangeReturnTypeNode(), which keeps adding a fresh@return array<...>tag on every pass while the invalid tag stays in place. The file never reaches a fixed point, so Rector loops until timeout.Bail out early when the
@returntag is invalid, mirroring the existinghasInvalidTag('@return')guard already used inPhpDocTypeChanger::changeReturnType().Reproducer:
Added
skip_invalid_return_tag.php.incto cover it.