Repository navigation
[DeadCode] Skip nested conditional assign in RemoveDefaultValueFromAssignedPropertyRector - #8915
Merged
Merged
Conversation
…signedPropertyRector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9957
RemoveDefaultValueFromAssignedPropertyRectorwrongly removed a property default when the only assign lived inside a nested if/else that is itself wrapped in an outer conditional:The outer
ifcan skip the whole block, so the property is not guaranteed to be assigned. Removing the default produced:ConstructorAssignDetector::isIfElseAssign()treated any if/else where both branches assign as guaranteed, ignoring that theifwas nested. The fix only counts the if/else when it is a first-level statement of the constructor, matching the existing guard used for direct assigns.