[kix]

Problem

AnnotationToAttributeRector turns every annotation argument into a named attribute argument. If the attribute constructor has no parameter of that name, PHP throws Unknown named parameter the moment the attribute is instantiated - while the annotation form was accepted.

I hit this migrating a Symfony 5.4 app. On 5.4 Length::__construct() has no allowEmptyString parameter, the setting is only reachable through $options:

/** @Assert\Length(min=1, max=400, allowEmptyString=true) */
// becomes
#[Assert\Length(min: 1, max: 400, allowEmptyString: true)]   // Error: Unknown named parameter $allowEmptyString

The error only shows up when the constraint metadata for that class is loaded, so it passes lint and static analysis.

Change

New UnknownNamedArgsToOptionsFolder, called from PhpAttributeGroupFactory::create(). When the attribute class is resolvable, its constructor has no parameter with a given name, and it has an array-accepting $options parameter, the unknown arguments are folded into it:

#[Assert\Length(min: 1, max: 400, options: ['allowEmptyString' => true])]

It is deliberately conservative and leaves the arguments untouched when:

• the attribute class cannot be resolved (so behaviour is unchanged where e.g. the vendor class is not installed - this is also why the existing Symfony fixtures are unaffected)
• the constructor has no $options parameter, or is variadic
• the argument is positional
• an explicit options: argument exists and is not an array literal

The check uses the project's installed class, so the result follows the installed Symfony version: on versions where the constructor does declare the parameter, it stays a named argument.

Tests

Three fixtures with stub attribute classes (Symfony's validator is not installed in this repo): unknown arg folded, known args stay named, no $options parameter left alone. The first fails without the change.

vendor/bin/phpunit passes (4874 tests) and ECS is clean. PHPStan reports the same 17 errors on main with and without this change, none in touched files. I did not run it against the real Symfony 5.4 Length class, only against the stubs.

Happy to adjust the approach if you would rather solve this differently (e.g. in rector-symfony).

🤖 Generated with Claude Code

[TomasVotruba]

Thank you