[CI] Fix drupal-rector dev-main smoke test blocked by stopgap conflict - #8479
Merged
Conversation
drupal-rector pins conflict rector/rector >=2.6.2 until it ports to composer-based sets, which blocks install in this downstream smoke test. Strip the conflict before require; all 695 drupal-rector tests pass against rector dev-main. Claude-Session: https://claude.ai/code/session_01SETBUG7QqwFNJUXQ42dLf1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Rector Drupal with dev-mainjob fails at install:drupal-rector added a stopgap
conflict: rector/rector >=2.6.2(their #420/#421) because rector 2.6.2 removed the version-specific set constants from extension packages in favor of composer-based sets. Their Drupal 8/9/10 configs still reference the old constants, so they pin the conflict until they finish porting (their #419).That conflict blocks our downstream smoke test even though the actual test suite is compatible - stripping the conflict and running their phpunit gives
OK (695 tests, 954 assertions)against rector dev-main.This strips the conflict key before
composer require, so the smoke test runs again. The one-liner is a no-op once drupal-rector lifts the conflict on their side.https://claude.ai/code/session_01SETBUG7QqwFNJUXQ42dLf1