[Php70] Deprecate ListSwapArrayOrderRector, can turn valid code into broken code - #8477
Merged
Merged
Conversation
TomasVotruba
force-pushed
the
tv-deprecate-list-swap-array-order
branch
from
September 9, 2026 07:51
1b255f3 to
3a69c96
Compare
TomasVotruba
enabled auto-merge (squash)
September 9, 2026 07:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListSwapArrayOrderRectorwraps the right-hand side of alist()assign witharray_reverse(), on the premise thatlist()fills its targets in reverse order. That reverse order only matters when the same array variable is assigned across items (list($a[], $a[]) = [1, 2];). The rule cannot reliably tell that apart from independent assigns, so it can wraparray_reverse()where it is not wanted and turn valid code into broken code.Deprecating it:
DeprecatedInterface, body throwsphp70andphp-version-basedsetshttps://claude.ai/code/session_015VSEwd6ef1TqwYumj3R1jn