Skip to content

[CodeQuality] Add DirnameDirConcatStringToDirectStringPathRector to set, deprecate DynamicDocBlockPropertyToNativePropertyRector - #8470

Merged
TomasVotruba merged 1 commit into
mainfrom
add-dirname-dir-concat-to-code-quality
Sep 8, 2026
Merged

[CodeQuality] Add DirnameDirConcatStringToDirectStringPathRector to set, deprecate DynamicDocBlockPropertyToNativePropertyRector#8470
TomasVotruba merged 1 commit into
mainfrom
add-dirname-dir-concat-to-code-quality

Conversation

@TomasVotruba

Copy link
Copy Markdown
Member

Two orphan rules (in no set) handled:

  • DirnameDirConcatStringToDirectStringPathRector - registered into the CodeQuality set/level. Safe cosmetic rule, added at the end of the list to avoid shifting existing level indices.
  • DynamicDocBlockPropertyToNativePropertyRector - deprecated. It turned a docblock @property (public by design) into a private native property, silently changing the access level and potentially breaking code relying on the public property. Body gutted to throw, tests removed.

…et, deprecate DynamicDocBlockPropertyToNativePropertyRector
@TomasVotruba
TomasVotruba force-pushed the add-dirname-dir-concat-to-code-quality branch from 6b19c52 to f760f5c Compare September 8, 2026 16:05
@TomasVotruba
TomasVotruba enabled auto-merge (squash) September 8, 2026 16:06
@TomasVotruba
TomasVotruba merged commit 5ac25a8 into main Sep 8, 2026
41 of 43 checks passed
@TomasVotruba
TomasVotruba deleted the add-dirname-dir-concat-to-code-quality branch September 8, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant