[Php80] Skip empty string needle in StrContainsRector - #8460
Merged
Conversation
strpos()/strstr() with empty needle returned false on PHP < 8, while str_contains() with empty needle returns true, so the conversion changed behavior. Skip when the needle is an empty string literal. Claude-Session: https://claude.ai/code/session_01Hczn76uiK4bDwdHM4rTMui
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9886
StrContainsRectorrewritesstrpos()/strstr() !== falsetostr_contains(). But with an empty string needle the two are not equivalent:strpos($haystack, '')returnedfalse, sostrpos($haystack, '') !== falsewasfalse.str_contains($haystack, '')returnstrue.So the conversion silently changed behavior for empty needles. This skips the rule when the needle is an empty string literal.
Added two skip fixtures for
strposandstrstr.https://claude.ai/code/session_01Hczn76uiK4bDwdHM4rTMui