[ax] Run Drupal dev-main check on main only, not on every PR - #8445
Merged
Conversation
TomasVotruba
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
rector_drupal_rector_dev.yamlran on every PR (pull_request: null). It clones an external repo (palantirnet/drupal-rector) and runs its phpunit againstrector:dev-main. That makes PR results depend on the state of a third-party repo - flaky and outside this repo's control.What
Drop the
pull_requesttrigger. The check still runs onpushtomain, so Drupal breakage is caught right after merge - just not gating each PR.Note
If this check is set as a required status check in branch protection, that entry should be removed too, otherwise PRs may wait on a check that no longer reports.