[ax] Disable progress bar when output is not a TTY - #8444
Merged
Conversation
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Rector is increasingly driven by non-human callers (agents, scripts) and piped/redirected output. In those contexts the progress bar is pure noise - it pollutes captured stdout and forces consumers to strip redraw sequences.
Currently the progress bar shows whenever output format is
consoleand verbosity is normal. Whether the output is an actual terminal is never checked;CiDetectoronly tunes the redraw rate, it does not turn the bar off.What
Short-circuit
shouldShowProgressBar()tofalsewhen STDOUT is not a TTY (piped output, CI, an agent). Interactive terminals are unaffected - the bar shows exactly as before.Behavior change to note
Non-TTY CI logs previously showed a
CiDetector-tuned (slow-redraw, non-overwriting) progress bar; they now show none. This is intentional - less log spam - but is a visible change for human CI users, not only agents.--no-progress-barand verbose modes behaved this way already; a real terminal is unchanged.CiDetectoris left in place for now; a follow-up can remove the redraw tuning that this makes largely redundant.Tests
composer check-cs- cleanvendor/bin/phpunit tests/Configuration/ConfigurationFactoryTest.php- green