[TypeDeclarationDocblocks] Skip empty array return in DocblockReturnArrayFromDirectArrayInstanceRector - #8434
Open
TomasVotruba wants to merge 1 commit into
Open
[TypeDeclarationDocblocks] Skip empty array return in DocblockReturnArrayFromDirectArrayInstanceRector#8434TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
…rrayFromDirectArrayInstanceRector A @return array{} is the narrowest array type. When added to a method that can be overridden, any child returning a filled array violates it. Empty array{} docblocks carry no useful information, so skip them entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A method that only does
return [];was annotated with@return array{}.array{}is the narrowest possible array type. Added to a base method, every child that overrides it and returns a filled array then violates the parent contract:An empty
array{}docblock carries no useful information anyway, so skip empty array returns entirely.The existing
return_emptyfixture asserted thearray{}output; it becomes a skip fixture.