Add fixtures for arrow functions returning a ?? expression - #8421
Merged
TomasVotruba merged 1 commit intoAug 31, 2026
Merged
Conversation
The rule had no coverage for an arrow function whose body is a null coalescing expression. On 2.6.4 all three of these cases were typed `: null`, which is a TypeError for the two that return a value.
samsonasik
approved these changes
Aug 31, 2026
Member
|
Thank you 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddArrowFunctionReturnTypeRectorhas no fixture where the arrow function body is a??expression. On 2.6.4 that case got the type wrong:Calling that throws a TypeError. Main gets all three cases below right already, so there is no source change here, just the fixtures to keep it that way:
?stringintmixedfrom an untyped array, no type addedOn 2.6.4 each one came out as
: null.