[dx] Deprecate SetList::INSTANCEOF, move rules into code-quality and type-declaration sets - #8408
Merged
Merged
Conversation
…n dead-code set Claude-Session: https://claude.ai/code/session_012HQ19gVsT8wVkekuVqVXGx
…anceOfRector from instanceof set, already in code-quality and type-declaration sets Claude-Session: https://claude.ai/code/session_012HQ19gVsT8wVkekuVqVXGx
…remove FlipNegatedTernaryInstanceofRector duplicate Move WhileNullableToInstanceofRector and BinaryOpNullableToInstanceofRector into TypeDeclarationLevel next to EmptyOnNullableObjectToInstanceOfRector. Drop FlipNegatedTernaryInstanceofRector from instanceof set, already in code-quality set. Claude-Session: https://claude.ai/code/session_012HQ19gVsT8wVkekuVqVXGx
Remove FlipTypeControlToUseExclusiveTypeRector (already in code-quality). The instanceof set is now empty as all its rules moved to code-quality and type-declaration sets; deprecate the constant. Claude-Session: https://claude.ai/code/session_012HQ19gVsT8wVkekuVqVXGx
TomasVotruba
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
instanceofset overlapped heavily withcode-qualityandtype-declaration. This consolidates the rules and deprecates the set:RemoveDeadInstanceOfRector(dead-code),InlineIsAInstanceOfRector+FlipNegatedTernaryInstanceofRector+FlipTypeControlToUseExclusiveTypeRector(code-quality),EmptyOnNullableObjectToInstanceOfRector(type-declaration).WhileNullableToInstanceofRectorandBinaryOpNullableToInstanceofRectorintoTypeDeclarationLevel, next toEmptyOnNullableObjectToInstanceOfRector.instanceofset is now empty;SetList::INSTANCEOFis deprecated in favor of the code-quality set.