[dx] Remove dead stub files no longer referenced - #8407
Merged
Conversation
Doctrine/Twig/Symfony stubs orphaned after rules moved to sibling packages; Php enum stubs are no-ops on required PHP ^8.4. Claude-Session: https://claude.ai/code/session_01F1pQDyMWREpFXpzyHFLpSY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes stub classes with zero references in
src/,rules/,rules-tests/,tests/,config/.Doctrine (rules moved to
rector-doctrine):stubs/Doctrine/DBAL/Connection.phpstubs/Doctrine/ORM/QueryBuilder.phpstubs/Doctrine/Persistence/ManagerRegistry.phpstubs/Doctrine/Persistence/ObjectManager.phpSymfony:
stubs/Symfony/Bridge/Doctrine/Validator/Constraints/UniqueEntity.php(only a regex101 comment matched)stubs/Symfony/Component/Validator/Constraints/Callback.phpTwig (RenameClass test uses
SandboxExtension+ local source, not these):stubs/Twig/Extension/AbstractExtension.phpstubs/Twig/Extension/ExtensionInterface.phpPHP enum stubs — no-ops on required PHP
^8.4; guardinterface_exists('BackedEnum')is always true, so the stub returns early:stubs/Php/BackedEnum.phpstubs/Php/UnitEnum.phpPHPStan level 8 clean, full test suite green.