[Tests] Trim redundant Issues regression tests - #8399
Merged
Conversation
TomasVotruba
force-pushed
the
tv-trim-issue-tests
branch
from
August 29, 2026 08:34
d5a5fb1 to
c8aaeca
Compare
TomasVotruba
force-pushed
the
tv-trim-issue-tests
branch
from
August 29, 2026 08:39
c8aaeca to
2636fc7
Compare
TomasVotruba
enabled auto-merge (squash)
August 29, 2026 08:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes 3
tests/Issues/*regression tests that no longer earn their keep:Issue6420- guardedRemoveDeadStmtRectornot eating apreg_replacecall thatRenameFunctionRectorrewrites to\Safe\preg_replace. Narrow 2021 edge, both rules now have solid own coverage.ConstructorPromoAnnotationToAttribute- docblock relocation into a promoted constructor param; covered byClassPropertyAssignToConstructorPromotionRectorown tests.AddClassDependency- symfony-only rule (GetBySymfonyStringToConstructorInjectionRector). ThePreferRequiredSettercase already exists in rector-symfony; the remaining "append to existing constructor" case is moved there in [DependencyInjection] Cover adding dependency into existing constructor rector-symfony#1061.Pure test removals - no engine or rule change.