Fix double backslash in FunctionFirstClassCallableRector - #8398
Merged
Conversation
TomasVotruba
enabled auto-merge (squash)
August 29, 2026 07:27
TomasVotruba
disabled auto-merge
August 29, 2026 07:27
Strip leading backslash before building the callable name so a fully qualified string callable like '\trim' produces \trim(...) instead of invalid \\trim(...). Claude-Session: https://claude.ai/code/session_01NAL2P8PQ3MY37Faby2r8st
TomasVotruba
force-pushed
the
tv-fix-first-class-callable-double-slash
branch
from
August 29, 2026 07:28
d8e75f5 to
fabecca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9871
FunctionFirstClassCallableRectorproduced invalid PHP for a fully qualified string callable with a leading backslash. The leading\was passed straight intoFullyQualified, which then printed a doubled backslash.Before the fix the output was
\array_map(\\trim(...), $input)- invalid syntax.Fix: strip the leading backslash before building the name and keep it fully qualified when one was present.