[cleanup] remove unused RelatedConfigInterface, fix couple phpstan errors - #8395
Merged
Conversation
TomasVotruba
force-pushed
the
tv-phpstan-5
branch
from
August 28, 2026 22:22
998e40b to
7efd6fb
Compare
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-phpstan-5
branch
from
August 28, 2026 22:40
97849e9 to
7efd6fb
Compare
TomasVotruba
force-pushed
the
tv-phpstan-5
branch
from
August 29, 2026 07:39
b73f26c to
ff58572
Compare
TomasVotruba
force-pushed
the
tv-phpstan-5
branch
from
August 29, 2026 08:26
fa313ac to
43a92f9
Compare
TomasVotruba
force-pushed
the
tv-phpstan-5
branch
2 times, most recently
from
August 29, 2026 08:36
c72c321 to
bbd0854
Compare
SanderMuller
added a commit
to hihaho/rector-rules
that referenced
this pull request
Aug 31, 2026
rectorphp/rector-src#8395 deleted `RelatedConfigInterface` and the `RectorConfig` block that imported a rule's `getConfigFile()`. The suffix rules implemented it, so loading them fatals on rector/rector 2.6.5: Interface "Rector\Contract\DependencyInjection\RelatedConfigInterface" not found Dropping the `implements` alone would be a silent downgrade — the config it pulled in (`config/related/rename-propagation.php`) was the only thing binding `SuffixRenameMap` as a singleton and registering `RenameClassRector` and `RenameDocBlockSeeTagRector`. Without it the rules rename declarations and leave every reference and `@see`/`@link`/`@uses` tag dangling. So the wiring moves to the package's own `config/config.php`, reached two ways: `extra.rector.includes` (hence the new `rector/extension-installer` require — its generated config is what `ExtensionConfigResolver` reads), and an explicit import from `config/sets/naming.php` so the set works even where the plugin is disallowed. Both are idempotent: `RectorConfig::rule()` records a class once. Registering unconditionally is free — both rules short-circuit on an empty rename map. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.