[Configuration] Deprecate and disable withSetProviders() - #8392
Merged
Conversation
Set providers are now loaded internally, so withSetProviders() is no longer applied - it emits E_USER_DEPRECATED and points to withComposerBased(). Drop the setGroups/groupLoadedSets plumbing and the composer-based set-group fallback; withComposerBased() now only loads defined set-list constants. Claude-Session: https://claude.ai/code/session_015hE4UdetizXAUwE7JKZHX7
With set providers gone, group matching always yielded nothing, so SetManager and its SetProviderCollector wiring are unused. Remove the class and update the extension composer-based test accordingly. Claude-Session: https://claude.ai/code/session_015hE4UdetizXAUwE7JKZHX7
TomasVotruba
force-pushed
the
deprecate-with-set-providers
branch
from
August 28, 2026 21:53
bcc7015 to
e0c8f1d
Compare
TomasVotruba
force-pushed
the
deprecate-with-set-providers
branch
from
August 28, 2026 21:58
7203f3a to
d864d57
Compare
Contributor
|
Why are features being removed in patch releases? Please review AI-generated changes for backward-compatible breaks before merging them. This change disabled every Rector extension that uses set providers. |
Member
Author
|
Because it no longer worked, as set providers are long gone. Poor design overriding future changes. This is how the sets were migrated in Laravel Rector: |
Contributor
|
Deprecations warn developers that an API may be removed or changed in a future major release. Incompatible API changes should not be introduced in minor or patch releases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set providers are now loaded internally, so
withSetProviders()is no longer applied. Calling it emits anE_USER_DEPRECATEDwarning and points towithComposerBased().Changes
withSetProviders()is a no-op that warns and returns$thissetGroups/groupLoadedSetsplumbing fromRectorConfigBuilderwithComposerBased()only loads defined set-list constants; the deprecated set-group fallback is goneSetManager(its group matching always resolved to nothing without providers)SetProviderCollectorstays as it is@apifor third-party bridges.https://claude.ai/code/session_015hE4UdetizXAUwE7JKZHX7