[CodeQuality] Add CoalesceToTernaryRector

[samsonasik]

Closes rectorphp/rector#9730

[samsonasik]

@TomasVotruba ready 👍

[samsonasik]

For note, it change behaviour, see

• https://3v4l.org/hbFf0#v8.5.3
• https://phpstan.org/r/70120c74-625a-4b26-8b5f-f1e140a595dd

which should be on purpose ...

[TomasVotruba]

Seems this would change behavior to different result.
What is the original use case in the real world this resolves?

[samsonasik]

This cause phpstan issue in the first place, which can be a wrong code to begin with

https://phpstan.org/r/42726037-b5d2-4b25-b627-f9b91e22021c

We had it in our project, which non nullable in the left, that's why I place it in the last order of code quality.

I can unregister it if needed because in case of eg string, and empty string passed, it goes left value over right one, while transformed result cause got right.

[TomasVotruba]

I can unregister it if needed because in case of eg string, and empty string passed, it goes left value over right one, while transformed result cause got right.

Let's do that and test it first. If it shows no edge-cases in next 2-3 months, we can add it to the set after.

[samsonasik]

sure, I've unregister it 👍 a7478ec

[TomasVotruba]

Thank you 👍

[github-actions]

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.