Skip to content

Make compatible with PHPStan 2.1.x-dev for ObjectType::equals() change behaviour - #7956

Merged
samsonasik merged 9 commits into
mainfrom
test-21xdev
Apr 5, 2026
Merged

samsonasik merged 9 commits into
mainfrom
test-21xdev

Conversation

@samsonasik

@samsonasik samsonasik commented Apr 5, 2026

Copy link
Copy Markdown
Member

@samsonasik samsonasik changed the title Test PHPStan 2.1.x-dev for ObjectType::equals() change behaviour Make compatible with PHPStan 2.1.x-dev for ObjectType::equals() change behaviour Apr 5, 2026
@samsonasik samsonasik self-assigned this Apr 5, 2026
@samsonasik

Copy link
Copy Markdown
Member Author

Fix on this rector-src repo, next is to checking the rector-downgrade-php :)

Screenshot 2026-04-05 at 17 27 24

@samsonasik

Copy link
Copy Markdown
Member Author

rector-downgrade-php patch handled at PR:

@samsonasik

Copy link
Copy Markdown
Member Author

The code compatible with test patched, let's rollback to original phpstan dependency :) a60efd2

@samsonasik

Copy link
Copy Markdown
Member Author

All green 🎉 @TomasVotruba let's merge ;)

@samsonasik
samsonasik merged commit c2251bd into main Apr 5, 2026
60 checks passed
@samsonasik
samsonasik deleted the test-21xdev branch April 5, 2026 10:39
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Rector is wrongly relying on ObjectType::equals implementation

2 participants