[ChangesReporting][Alternative] Collect changed_files on --no-diffs with json output with use of JsonOutputFactory - #7821
Conversation
0a2abd2 to
8f69825
Compare
|
@peterfox on running via cli, it somehow not show the list of file changed (even your original PR). ➜ rector-src git:(use-factory) ✗ bin/rector process src/Application/VersionResolver.php --output-format=json --no-diffs --dry-run
{
"totals": {
"changed_files": 1,
"errors": 0
}
}so it seems need change on I will look more, mark as draft for now :) |
This reverts commit e9b5a0f.
…st for cross OS usage
|
this needs e2e test |
|
I've added e2e test to show it still not working on cli command 33d9f9a that it seems require change on file processor somewhere... https://github.com/rectorphp/rector-src/actions/runs/22897852101/job/66436469748?pr=7821#step:7:17 |
|
Fixed with check on WorkerCommand as well 👍 /cc @peterfox |
|
@TomasVotruba this one alternative is ready for review 👍
|
|
Let's ship it then, thank you guys 🙏 |
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
to make easy test for cross OS usage.
Continue of PR:
Closes #7808