Error with merged carbon imports with importNames and removeUnusedImports.

[BinaryKitten]

When using Carbon as a class and the CarbonInterface - we get a weird merged import process.

this imports use Carbon\Carbon\CarbonInterface which is not valid.

Test case here in PR
Demo
https://getrector.com/demo/14fa4e52-32b1-4931-811e-17d522a8c833

[samsonasik]

The removeUnusedImports doesn't detect @property for now, I will check if that can be detected ;)

[BinaryKitten]

it's weird that its creating the use Carbon\Carbon\CarbonInterface; and use Illuminate\Support\Carbon\CarbonInterface lines, both of which are invalid though?

It only occurs when there's a class named the start of the other - otherwise it doesn't import the @property - which is almost better (having @property support would be great - but would setting for not breaking the import with invalid merged class name/namespace.

[BinaryKitten]

@samsonasik if you could point me in the general direction - i'd love to submit a possible fix - learn more and be useful :)

[samsonasik]

@BinaryKitten the remove unused imports is on UnusedImportRemovingPostRector, it basically if @property type can be fetch, it will be correctly detected, see this part:

rector-src/src/PostRector/Rector/UnusedImportRemovingPostRector.php

Lines 163 to 173 in 540fbfa

	$phpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($nodeToCheck);
	$names = [...$names, ...$phpDocInfo->getAnnotationClassNames()];
	$constFetchNodeNames = $phpDocInfo->getConstFetchNodeClassNames();
	$names = [...$names, ...$constFetchNodeNames];
	$genericTagClassNames = $phpDocInfo->getGenericTagClassNames();
	$names = [...$names, ...$genericTagClassNames];
	$arrayItemTagClassNames = $phpDocInfo->getArrayItemNodeClassNames();
	$names = [...$names, ...$arrayItemTagClassNames];

To add more resolved class, you can add more PhpDocNodeDecoratorInterface implementation, for example:

rector-src/src/BetterPhpDocParser/PhpDocParser/ConstExprClassNameDecorator.php

Line 20 in 540fbfa

final readonly class ConstExprClassNameDecorator implements PhpDocNodeDecoratorInterface

then register it:

rector-src/src/DependencyInjection/LazyContainerFactory.php

Lines 333 to 338 in 540fbfa

	private const PHP_DOC_NODE_DECORATOR_CLASSES = [
	ConstExprClassNameDecorator::class,
	DoctrineAnnotationDecorator::class,
	ArrayItemClassNameDecorator::class,
	PhpDocTagGenericUsesDecorator::class,
	];

then, you may can fetch via PhpDocInfo :)

[samsonasik]

this only for autoimport + remove, nothing todo with rename, so you can move these fixture tests to tests/Issues/NamespacedUseAutoImport which only check on this functionality for auto import + remove unused import:

https://github.com/rectorphp/rector-src/tree/main/tests/Issues/NamespacedUseAutoImport/Fixture

[samsonasik]

handled at #7957

[github-actions]

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.