Skip to content

[Php85] Skip defined int or string on ArrayKeyExistsNullToEmptyStringRector - #7758

Merged
TomasVotruba merged 3 commits into
mainfrom
skip-non-nullable
Dec 25, 2025
Merged

[Php85] Skip defined int or string on ArrayKeyExistsNullToEmptyStringRector#7758
TomasVotruba merged 3 commits into
mainfrom
skip-non-nullable

Conversation

@samsonasik

Copy link
Copy Markdown
Member

Ref https://getrector.com/demo/5dee0eb0-aea7-4e62-88a4-90f54eae39de
Fixes rectorphp/rector#9560

array_key_exists allow both int or string key.

@samsonasik

Copy link
Copy Markdown
Member Author

Fixed 🎉 /cc @MaxencePaulin

@samsonasik

Copy link
Copy Markdown
Member Author

@TomasVotruba ready 👍

@samsonasik

Copy link
Copy Markdown
Member Author

@TomasVotruba mergeable?

@samsonasik

Copy link
Copy Markdown
Member Author

@TomasVotruba ready 👍

@TomasVotruba

Copy link
Copy Markdown
Member

Much better, thank you 👍

@TomasVotruba
TomasVotruba merged commit 3288dc1 into main Dec 25, 2025
58 checks passed
@TomasVotruba
TomasVotruba deleted the skip-non-nullable branch December 25, 2025 12:15
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

ArrayKeyExistsNullToEmptyStringRector forces me to cast to string when it is not necessary

3 participants